Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a CommandNameFormatter #10

Open
amazium opened this issue Jan 31, 2019 · 1 comment
Open

Adding a CommandNameFormatter #10

amazium opened this issue Jan 31, 2019 · 1 comment

Comments

@amazium
Copy link

amazium commented Jan 31, 2019

Currently there is a ClassNameFormatter. This is useful when the ClassName is the command name, but if our CommandHandlerMiddleware uses a different CommandNameExtractor it isn't.

I propose adding an extra formatter CommandNameFormatter that accepts a CommandNameExtractor as a parameter. Other logic similar to the ClassNameFormatter.

@rosstuck
Copy link
Member

rosstuck commented Feb 10, 2019

Can do, though would it be easier to create a custom implementation of the Formatter interface for your specific project? For Tactician2 (if I ever get time), I'm likely going to drop the ClassNameFormatter concept entirely and default to just get_class across the board, since I think FQCNs have become the de facto implementation for most projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants