Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Didn't close connection properly when error #251

Closed
4 tasks done
Originalimoc opened this issue Nov 23, 2024 · 2 comments
Closed
4 tasks done

[BUG] Didn't close connection properly when error #251

Originalimoc opened this issue Nov 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Originalimoc
Copy link

OS

Windows

GPU Library

CUDA 12.x

Python version

3.12

Describe the bug

Stuck at unloading model after a Job required xx pages error then you try to load a new model.
Then you Ctrl + C, it shows: "waiting connection to close(Ctrl+C to force quit)"

Reproduction steps

Load a model with max_seq_len low. Then try query above it you'll get an error. Now you load a new model, it will stuck at unloading model.

Expected behavior

Job properly cancelled and load the new model.

Logs

No response

Additional context

Detailed lost but happened multiple times already and maybe later reproduced again.

Acknowledgements

  • I have looked for similar issues before submitting this one.
  • I have read the disclaimer, and this issue is related to a code bug. If I have a question, I will use the Discord server.
  • I understand that the developers have lives and my issue will be answered when possible.
  • I understand the developers of this program are human, and I will ask my questions politely.
@Originalimoc Originalimoc added the bug Something isn't working label Nov 23, 2024
@DocShotgun
Copy link
Member

Able to reproduce locally. Interestingly it seems like if you first unload the model manually via the /v1/model/unload endpoint before trying to load the new model, it doesn't get stuck like this.

@kingbri1
Copy link
Member

Solved in 7094938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants