Catch potential NULL return value from preg_replace_callback

For reference: issue #356
theseer · Mar 19, 2019 · ab50417 · ab50417 · jan-koch · Apr 14, 2020
1 parent 4c04bab
commit ab50417
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/collector/backend/SourceFileException.php b/src/collector/backend/SourceFileException.php
@@ -3,6 +3,6 @@
 
 class SourceFileException extends \Exception {
     public const BadEncoding = 1;
-
     public const InvalidDataBytes = 2;
+    public const RegexError = 3;
 }
diff --git a/src/collector/project/SourceFile.php b/src/collector/project/SourceFile.php
@@ -43,7 +43,7 @@ public function getSource(): string {
 
         $source = \file_get_contents($this->getPathname());
 
-        if ($source == '') {
+        if ($source === '') {
             $this->src = '';
 
             return '';
@@ -71,6 +71,13 @@ function (array $matches) {
             $source
         );
 
+        if ($this->src === null) {
+            throw new SourceFileException(
+                sprintf('Error %d while executing regular expression callback', \preg_last_error()),
+                SourceFileException::RegexError
+            );
+        }
+
         return $this->src;
     }