Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is allow-deprecated-apis=true still needed? #6

Open
Sjors opened this issue Jul 9, 2024 · 0 comments
Open

Is allow-deprecated-apis=true still needed? #6

Sjors opened this issue Jul 9, 2024 · 0 comments

Comments

@Sjors
Copy link

Sjors commented Jul 9, 2024

And if so, is there a more narrow config option to enable one specific deprecated API?

Related code:

// Currently there is some debate over whether the description hash should be known or not before paying.
// The change in CLN requiring the description was reverted but it is still deprecated
// With NIP47 as of now the description is unknown
// This may need to be reviewed in the future
// https://github.com/ElementsProject/lightning/pull/6092
// https://github.com/ElementsProject/lightning/releases/tag/v23.02.2
let _description = match bolt11.description() {
Bolt11InvoiceDescription::Direct(des) => des.to_string(),
Bolt11InvoiceDescription::Hash(hash) => hash.0.to_string(),
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant