Rename *MIN_SCRAMBLE_LENGTH variables and check that they actually work

[jfly]

See thewca/tnoodle#156 (comment) for renaming the variables, and thewca/tnoodle#156 (comment) for checking that pyraminx and 222 are always solvable in exactly God's number turns.

@chenshuang, do you think you can take this issue on when you've got some free time? There's no immediate rush here, but it's definitely something that should be done eventually.

[cs0x7f]

OK. I'll check the assumption in about 2 weeks. BTW, the solution of pyraminx does not include tips, which means that the length might larger than "MIN_SCRAMBLE_LENGTH" or "EXACT_SCRAMBLE_LENGTH".

[lgarron]

Wait, then how do we filter Pyraminx?

»Lucas Garron

On Wed, Jan 8, 2014 at 1:24 AM, Chen Shuang [email protected]:

OK. I'll check the assumption in about 2 weeks. BTW, the solution of
pyraminx does not include tips, which means that the length might larger
than "MIN_SCRAMBLE_LENGTH" or "EXACT_SCRAMBLE_LENGTH".

—
Reply to this email directly or view it on GitHubhttps://github.com/cubing/tnoodle/issues/158#issuecomment-31816055
.

[cs0x7f]

The length includes tips. The filtering is correct.

[jfly]

I believe Chen Shuang is referring to the SCRAMBLE_LENGTH_INCLUDES_TIPS boolean in PyraminxPuzzle.java. I vaguely remember us having to deal with this.