Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy PHP redirects no longer work #9133

Open
jfly opened this issue Mar 28, 2024 · 2 comments
Open

Legacy PHP redirects no longer work #9133

jfly opened this issue Mar 28, 2024 · 2 comments

Comments

@jfly
Copy link
Contributor

jfly commented Mar 28, 2024

Describe the bug

Urls like https://www.worldcubeassociation.org/results/p.php?i=2007COHE01 result in a 404.

Expected behavior

I expect these urls to redirect to their modern equivalent. In the example above, that would be https://www.worldcubeassociation.org/persons/2007COHE01.

I suspect this broke last month when c0fb355#r140357389 got merged up. You can see in chef/site-cookbooks/wca/templates/worldcubeassociation.org.conf.erb that there was a whole section titled "Legacy PHP redirects" that I suspect didn't get ported anywhere.

Why is this important?

Cool URIs don't change. We can't control all the existing webpages out there that link to the WCA website (think of all the news articles and now-unmaintained personal websites). Whenever possible, the WCA website should preserve these old links.

@jfly
Copy link
Contributor Author

jfly commented Jun 25, 2024

Ping. @FinnIckler, was this change intentional? Is this something you'd be open to a PR implementing?

@FinnIckler
Copy link
Member

This was intentional yes. It's because we dropped the nginx and didn't want to invest any time recreating this with Rails. I don't think I'll personally open a PR for this, but we probably would accept contributions (@gregorbg tell me if I'm wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants