Make peek() use shm:ttl() to avoid touching shm LRU #39
Labels
Comments
thibaultcha
added a commit
that referenced
this issue
Jun 5, 2018
Use the new `shm:ttl()` API which was contributed in order to support mlcache's `peek()` method. The existing `peek()` implementation was a temporary solution until then. It is slightly unfortunate that we chose to return the value along with the remaining TTL, as this behavior now must break. Pros/cons --------- + As a result, `peek()` is ligher and thus, faster + It does not touch the shm LRU queue - It is a breaking change Fix #39
thibaultcha
added a commit
that referenced
this issue
Jun 5, 2018
Use the new `shm:ttl()` API which was contributed in order to support mlcache's `peek()` method. The existing `peek()` implementation was a temporary solution until then. It is slightly unfortunate that we chose to return the value along with the remaining TTL, as this behavior now must break. Pros/cons --------- + As a result, `peek()` is ligher and thus, faster + It does not touch the shm LRU queue - It is a breaking change Fix #39
thibaultcha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this would be breaking because we would not retrieve "value" anymore - can be added as an option
The text was updated successfully, but these errors were encountered: