RUSTSEC-2024-0421: idna
accepts Punycode labels that do not produce any non-ASCII when decoded
#197
Labels
dependencies
Pull requests that update a dependency file
rust
Pull requests that update Rust code
security dependencies
security cause by dependencies
idna
0.4.0
idna
0.5.0 and earlier accepts Punycode labels that do not produce any non-ASCII output, which means that either ASCII labels or the empty root label can be masked such that they appear unequal without IDNA processing or when processed with a different implementation and equal when processed withidna
0.5.0 or earlier.Concretely,
example.org
andxn--example-.org
become equal after processing byidna
0.5.0 or earlier. Also,example.org.xn--
andexample.org.
become equal after processing byidna
0.5.0 or earlier.In applications using
idna
(but not inidna
itself) this may be able to lead to privilege escalation when host name comparison is part of a privilege check and the behavior is combined with a client that resolves domains with such labels instead of treating them as errors that preclude DNS resolution / URL fetching and with the attacker managing to introduce a DNS entry (and TLS certificate) for anxn--
-masked name that turns into the name of the target when processed byidna
0.5.0 or earlier.Remedy
Upgrade to
idna
1.0.3 or later, if depending onidna
directly, or tourl
2.5.4 or later, if depending onidna
viaurl
. (This issue was fixed inidna
1.0.0, but versions earlier than 1.0.3 are not recommended for other reasons.)When upgrading, please take a moment to read about alternative Unicode back ends for
idna
.If you are using Rust earlier than 1.81 in combination with SQLx 0.8.2 or earlier, please also read an issue about combining them with
url
2.5.4 andidna
1.0.3.Additional information
This issue resulted from
idna
0.5.0 and earlier implementing the UTS 46 specification literally on this point and the specification having this bug. The specification bug has been fixed in revision 33 of UTS 46.Acknowledgements
Thanks to kageshiron for recognizing the security implications of this behavior.
The text was updated successfully, but these errors were encountered: