Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing and reimplementing dependencies between SectionReport and BasicReport implementations #112

Open
hidakatsuya opened this issue Aug 7, 2021 · 0 comments · May be fixed by #124
Open

Removing and reimplementing dependencies between SectionReport and BasicReport implementations #112

hidakatsuya opened this issue Aug 7, 2021 · 0 comments · May be fixed by #124
Labels
enhancement New feature or request section-report For Section Report

Comments

@hidakatsuya
Copy link
Member

hidakatsuya commented Aug 7, 2021 •
edited
Loading

  • Remove dependencies between SectionReport and BasicReport implementations and make them independent
  • Improve complex implementation due to their dependencies (e.g., section_height.rb, draw_item.rb)
@hidakatsuya hidakatsuya added enhancement New feature or request section-report For Section Report labels Aug 7, 2021
@hidakatsuya hidakatsuya linked a pull request May 21, 2023 that will close this issue
Draft
@hidakatsuya hidakatsuya changed the title section report の実装のリファクタリング Removing and reimplementing dependencies between SectionReport and BasicReport implementations May 21, 2023
@hidakatsuya hidakatsuya moved this to 🚩 v1.0.0 in v1.0.0 May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request section-report For Section Report
Projects
v1.0.0
Status: 🚩 v1.0.0
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New implementation for section report thinreports/thinreports-generator
1 participant
@hidakatsuya