Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code formatting #136

Open
elyas-bhy opened this issue Apr 3, 2018 · 2 comments
Open

Update code formatting #136

elyas-bhy opened this issue Apr 3, 2018 · 2 comments

Comments

@elyas-bhy
Copy link
Collaborator

elyas-bhy commented Apr 3, 2018

Is maintaining compatibility with Node 4.x a priority, or could we bump it up to at least Node 6.9 (LTS)?
This would allow us to use the newer ES6 syntax, such as the class construct, const, let, arrow functions, etc. This would also be timely with the upcoming major release.

Furthermore, could we update the linter to allow 2-spaces indents and 100 max line length?

@thisandagain
Copy link
Owner

thisandagain commented Apr 25, 2018

I think with the work coming in as part of #128 I'd be happy to do a major version change and update the minimum engine to Node 8. Yay ES6 syntax! 🎉

I'd prefer to keep the style stuff where it is. It's a lot of work to maintain so many repos (personal, Scratch, Mozilla, etc.) and it's really helpful to have one consistent set of style rules across my stuff.

@thisandagain
Copy link
Owner

Update: with 5.0.0 we have updated the minimum engine to Node 8.0.0. Happy to accept PRs that migrate over to usage of const, let, arrow functions, and ES6 class syntax. Note that our eslint config will need to be updated at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants