Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tags are on detached commits #101

Open
TapaiBalazs opened this issue Jul 7, 2022 · 1 comment
Open

Release tags are on detached commits #101

TapaiBalazs opened this issue Jul 7, 2022 · 1 comment
Assignees
Labels
blocked chore help wanted Extra attention is needed

Comments

@TapaiBalazs
Copy link
Contributor

When we run the release pipeline, it pushes up the tags to github, but the commits that increase the version number in the package.json file are not part of the main branch. Cherry-picking them won't change the link of the tags.

I imagine what we would need to do in the release pipeline is to open a branch, where the pipeline can commit and push it up, and then open a PR to the main branch that we can merge automatically.

@TapaiBalazs TapaiBalazs added help wanted Extra attention is needed chore labels Jul 7, 2022
@TapaiBalazs TapaiBalazs self-assigned this Jul 14, 2022
@TapaiBalazs
Copy link
Contributor Author

I was able to create a PR with the commit pushed, but I encountered 2 problems:

  1. The PR checks didn't run at all
  2. When I squash merged it, the tag was not merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked chore help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant