Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency launch: CONCURRENCY_BROWSER definition slightly misleading #520

Open
goelayu opened this issue Apr 4, 2023 · 3 comments
Open

Comments

@goelayu
Copy link

goelayu commented Apr 4, 2023

Not sure if others would agree, but I felt the definition of CONCURRENCY_BROWSER that every URL is launched in a new browser using the incognito context, seemed misleading to me.

Technically, it spawn one browser per worker, and creates a new incognito context (and a new page) per URL.

Spawning an entirely new browser per URL, would significantly inflate the loading cost (in terms of CPU usage) of each URL (as per some of my experiments).

@goelayu goelayu changed the title Concurrency launch: Concurrency browser definition slightly misleading Concurrency launch: CONCURRENCY_BROWSER definition slightly misleading Apr 4, 2023
@tehandyb
Copy link

It says CONCURRENCY_BROWSER launches one browser per url, and CONCURRENCY_CONTEXT launches an incognito page per url. So if what you're saying is true, and it only spawns one browser per worker, I would agree the docs should be updated :)

@goelayu
Copy link
Author

goelayu commented Jun 1, 2023

Yes, CONCURRENCY_BROWSER launches one browser per worker, and not per URL. @thomasdondorf feel free to update the READme if you agree.

@localhost-MouhannadlrX
Copy link

Agree with you @goelayu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants