Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm results about PDQN/HPPO in gym-hybrid #3

Open
PaParaZz1 opened this issue Oct 12, 2021 · 2 comments
Open

Algorithm results about PDQN/HPPO in gym-hybrid #3

PaParaZz1 opened this issue Oct 12, 2021 · 2 comments
Assignees

Comments

@PaParaZz1
Copy link
Contributor

Hi, this is a nice project for hybrid action space, and I see you mentioned PDQN/HPPO in README.md. Do you have some experiment results about these algorithms in this environment. If not, we want to invite you to implement related algorithms and benchmarks in our repo DI-engine together, we will offer corresponding supports for you. Do you have will to construct a hybrid action space RL benchmark? Other comments are also welcome.

@PaParaZz1
Copy link
Contributor Author

PaParaZz1 commented Oct 26, 2021

We implement PADDPG in your gym-hybrid env in this link

@thomashirtz
Copy link
Owner

Thank you very much for your feedback!
Unfortunately these days I am very busy and I cannot take care of it.
I did implement P-QLearning in my q-learning-algorithms in the past, I do not remember if it converged or the score.

Note: Algorithms are now using architectures that needs to know the which parameters are related to which action (e.g. MP-DQN). I think it may be better to change the way to handle the observation space. I am not completely sure yet what is the best way to do it. Even though it would definitely future-proof the repository, it would also break any agent that used this env...
gym-platform is using one tuple of space per parameter-action pair, didn't test how inconvenient it is to have empty tuple (e.g. for breaking).

@thomashirtz thomashirtz self-assigned this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants