From bdb7e39afb9ea25a0026f06958c1eade9eacb6c7 Mon Sep 17 00:00:00 2001 From: Thomas Lin Pedersen Date: Thu, 18 Jan 2024 08:59:47 +0100 Subject: [PATCH] Fix #307 --- NEWS.md | 2 ++ R/mark_rect.R | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index c0651d9..5904a48 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,8 @@ * The concaveman package is no longer a dependency for `geom_mark_hull()` (#308) * Setting both label and description to `NA` will now turn off label drawing for that mark completely while still drawing the mark +* Fix a bug in `geom_mark_rect()` where the mark would not be shown in all + panels (#307) # ggforce 0.4.1 diff --git a/R/mark_rect.R b/R/mark_rect.R index 5cea216..0b472e2 100644 --- a/R/mark_rect.R +++ b/R/mark_rect.R @@ -79,7 +79,7 @@ GeomMarkRect <- ggproto('GeomMarkRect', GeomMarkCircle, data <- data[data$filter, ] } if (nrow(data) == 0) return(data) - vec_rbind(!!!lapply(split(data, data$group), function(d) { + vec_rbind(!!!lapply(split(data, list(data$PANEL, data$group)), function(d) { if (nrow(d) == 1) return(d) x_range <- range(d$x, na.rm = TRUE) y_range <- range(d$y, na.rm = TRUE)