From 253f7907d6a5051db6c87dd64578076f27b9f55b Mon Sep 17 00:00:00 2001 From: Thomas Poignant Date: Wed, 27 Nov 2024 23:15:13 +0100 Subject: [PATCH] adding pro/con solution 2 Signed-off-by: Thomas Poignant --- website/src/pages/specification/20241027-flagsets.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/website/src/pages/specification/20241027-flagsets.md b/website/src/pages/specification/20241027-flagsets.md index 6809ca3794c8..9611b4bb2f4e 100644 --- a/website/src/pages/specification/20241027-flagsets.md +++ b/website/src/pages/specification/20241027-flagsets.md @@ -144,6 +144,7 @@ authorizedKeys: - It is easy to give ownership of a flag set to a team, by giving them access to the file. **CON** +- The flag set configuration is at the same place as the flag configuration, so it is possible to edit the flag set name directly inside the file _(risk of overriding another flag set)_. - If we want the same flag to be part of multiple flag sets, we need to duplicate the flag in multiple files. ### Solution 2: specify the flag set in the retriever configuration @@ -190,6 +191,16 @@ authorizedKeys: admin: - apikey3 ``` + +**PRO** +- It is simple to configure a flag set by putting all the flags at the same place. +- It is easy to understand which flags are part of a flag set. +- It is easy to give ownership of a flag set to a team, by giving them access to the file. +- The flag set name is directly associated to the retriever, so it is not possible to edit it directly inside the file. + +**CON** +- If we want the same flag to be part of multiple flag sets, we need to duplicate the flag in multiple files. + ### Solution 3 :::note Feel free to propose other solutions here.