Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for multiple exporters #3171

Merged
merged 34 commits into from
Mar 7, 2025
Merged

feat: support for multiple exporters #3171

merged 34 commits into from
Mar 7, 2025

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Mar 6, 2025

Description

This PR enable the possibility to have multiple exporter at the same time.

Under the hood we have a shared cache (with offset) that allows to store all the events in memory before publishing them to the exporters.
If for any reason the exporter is not responding we are keeping the event for the next call.

Closes issue(s)

Resolve #2505

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <[email protected]>
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 32f0492
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67cb613b65c95f0008084b99

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 90.75908% with 28 lines in your changes missing coverage. Please review.

Project coverage is 85.66%. Comparing base (5caf22c) to head (32f0492).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/event_store.go 87.61% 9 Missing and 4 partials ⚠️
cmd/relayproxy/service/gofeatureflag.go 82.05% 7 Missing ⚠️
cmd/relayproxy/config/config.go 83.87% 4 Missing and 1 partial ⚠️
exporter/manager.go 93.02% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
+ Coverage   84.95%   85.66%   +0.71%     
==========================================
  Files         113      115       +2     
  Lines        5276     5475     +199     
==========================================
+ Hits         4482     4690     +208     
+ Misses        630      615      -15     
- Partials      164      170       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant changed the title Multiple exporters feat: support for multiple exporters Mar 7, 2025
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant marked this pull request as ready for review March 7, 2025 15:14
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Copy link

sonarqubecloud bot commented Mar 7, 2025

@kodiakhq kodiakhq bot merged commit 25356a0 into main Mar 7, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the multiple-exporters branch March 7, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Support for multiple exporters
1 participant