Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature comparison between this and the rustc_arena crate. #28

Open
crlf0710 opened this issue Aug 15, 2019 · 2 comments
Open

Feature comparison between this and the rustc_arena crate. #28

crlf0710 opened this issue Aug 15, 2019 · 2 comments

Comments

@crlf0710
Copy link

crlf0710 commented Aug 15, 2019

In rustc_arena crate within rustc tree, there are three types DroplessArena, SyncTypedArena, and SyncDroplessArena that's not in this crate. Is it possible/feasible to provide them in this crate?

@pczarn
Copy link
Collaborator

pczarn commented Nov 23, 2019

Yes, I will try to provide them.

@thomcc thomcc changed the title Feature comparison between this and the libarena crate. Feature comparison between this and the rustc_arena crate. Jan 9, 2023
@thomcc
Copy link
Owner

thomcc commented Jan 9, 2023

(libarena got renamed to rustc_arena some time ago, so I've updated the title and question).

I believe these crates have some shared history, but am unaware of the details. If I find out it would be reasonable to document somewhere.

In practice, a major difference in practice is that rustc_arena is not on crates.io. It can only be used in rustc (or projects that use #![feature(rustc_private)] or whatever it's called). Additionally, it's full of unstable features so even if it were on crates.io, it could not be used by many users. This crate has neither of those downsides.

On the other hand this crate currently has a few missing features compared to rustc_arena and is a bit less optimized, although I'm hoping to fix both of these issues when I find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants