Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

RunCLPFormula function in CLP Keeper uses float precision #15

Open
musnit opened this issue Aug 28, 2018 · 0 comments
Open

RunCLPFormula function in CLP Keeper uses float precision #15

musnit opened this issue Aug 28, 2018 · 0 comments
Labels
security Label for potential security issues

Comments

@musnit
Copy link
Contributor

musnit commented Aug 28, 2018 •
edited
Loading

It is unclear/needs to be checked whether this is 100% secure. May be necessary to implement power and n-th root Math functions to work on int64s with int64 precision.

Cosmos has not implemented coins with decimal values yet either, so likely want to defer until then too

Also need to check risk of exploiting/slowly draining tokens due to rounding errors
@musnit musnit changed the title CalculateTokensIssued function uses float precision CalculateTokensIssued function in CLP Keeper uses float precision Aug 28, 2018
@musnit musnit added the security Label for potential security issues label Aug 28, 2018
@musnit musnit changed the title CalculateTokensIssued function in CLP Keeper uses float precision RunCLPFormula function in CLP Keeper uses float precision Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
security Label for potential security issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@musnit