fix: corrected handling of restricted groups, closes #2953

thorsten · May 16, 2024 · 1026374 · 1026374
1 parent 9e73893
commit 1026374
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/phpmyfaq/assets/templates/admin/content/faq.editor.twig b/phpmyfaq/assets/templates/admin/content/faq.editor.twig
@@ -240,7 +240,7 @@
                       <label class="form-check-label" for="restrictedgroups">
                         {{ ad_entry_restricted_groups }}
                       </label>
-                      <select id="restrictedgroups" name="restricted_groups[]" size="3" class="form-control" multiple>
+                      <select id="restrictedgroups" name="restricted_groups" size="3" class="form-control" multiple>
                         {{ groupPermissionOptions | raw }}
                       </select>
                     </div>

diff --git a/phpmyfaq/src/phpMyFAQ/Faq/Permission.php b/phpmyfaq/src/phpMyFAQ/Faq/Permission.php
@@ -152,9 +152,11 @@ public function createPermissionArray(): array
                 'restricted_groups' => [-1],
             ];
         } else {
-            $permissions += Filter::filterArray(
-                $data->restricted_groups
-            );
+            $permissions += [
+                'restricted_groups' => [
+                    Filter::filterArray($data->{'restricted_groups'}, FILTER_VALIDATE_INT),
+                ]
+            ];
         }
 
         return $permissions;