refactor: improved code

thorsten · Oct 19, 2024 · c5b5f10 · c5b5f10
1 parent 7dfaa0e
commit c5b5f10
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/phpmyfaq/admin/record.edit.php b/phpmyfaq/admin/record.edit.php
@@ -221,7 +221,7 @@
 
     // Group permissions
     $groupPermission = $faqPermission->get(FaqPermission::GROUP, $faqData['id']);
-    if (count($groupPermission) == 0 || $groupPermission[0] == -1) {
+    if (empty($groupPermission) || in_array(-1, $groupPermission, true)) {
         $allGroups = true;
         $restrictedGroups = false;
         $groupPermission[0] = -1;

diff --git a/phpmyfaq/src/phpMyFAQ/Faq/FaqPermission.php b/phpmyfaq/src/phpMyFAQ/Faq/FaqPermission.php
@@ -87,9 +87,8 @@ public function delete(string $mode, int $faqId): bool
             $mode,
             $faqId
         );
-        $this->config->getDb()->query($query);
 
-        return true;
+        return (bool) $this->config->getDb()->query($query);
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -87,9 +87,8 @@ public function delete(string $mode, int $faqId): bool @@
                 $mode,
                 $faqId
             );
-            $this->config->getDb()->query($query);
-            return true;
+            return (bool) $this->config->getDb()->query($query);
         }
         /**
@@ Expand Down @@