Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a commit with report in a repo #250

Open
1 of 3 tasks
pacospace opened this issue Apr 16, 2021 · 15 comments
Open
1 of 3 tasks

Create a commit with report in a repo #250

pacospace opened this issue Apr 16, 2021 · 15 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/observability Categorizes an issue or PR as relevant to SIG Observability triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pacospace
Copy link
Contributor

pacospace commented Apr 16, 2021 •
edited by codificat
Loading

Is your feature request related to a problem? Please describe.
As Maintainer/Manager,

I would like to see reports directly into a GitHub Repo.

The reports are currenty being sent via email and are not persisted in the repo

Describe the solution you'd like

  • HTML report can be stored using env variable
  • Create/reuse a repo where to store HTML reports that are rendered.

Describe alternatives you've considered

Additional context
cc @goern

Acceptance criteria

  • a commit is automatically created in the repo when the SLO reports are generated
@pacospace pacospace self-assigned this May 6, 2021
@pacospace pacospace added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 12, 2021
@pacospace pacospace mentioned this issue May 12, 2021
Merged
@pacospace pacospace added the triage/needs-information Indicates an issue needs more information in order to work on it. label May 12, 2021
@harshad16 harshad16 removed the triage/needs-information Indicates an issue needs more information in order to work on it. label May 12, 2021
@goern
Copy link
Member

goern commented May 17, 2021

will we wrap this up in an argo workflow? 1. step to create the report, 2. commit? don't we have that functionality in other workflows?

@pacospace
Copy link
Contributor Author

pacospace commented May 18, 2021 •
edited
Loading

will we wrap this up in an argo workflow? 1. step to create the report, 2. commit? don't we have that functionality in other workflows?

Yes in the future wil be an argo CronWorkflow with different steps, as of now, a new method using source-management library

@sesheta
Copy link
Member

sesheta commented Jul 15, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Jul 15, 2021
@sesheta
Copy link
Member

sesheta commented Jul 15, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Jul 15, 2021
@goern goern added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 16, 2021
@sesheta
Copy link
Member

sesheta commented Aug 24, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2021
@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Sep 23, 2021
@pacospace pacospace reopened this Sep 27, 2021
@sesheta
Copy link
Member

sesheta commented Oct 27, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Oct 27, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Oct 27, 2021
@codificat
Copy link
Member

this was auto-closed 1 month after reopening. I believe the intention was:
/reopen
/lifecycle frozen
feel free to correct if that's not the case

@sesheta sesheta reopened this Oct 27, 2021
@sesheta
Copy link
Member

sesheta commented Oct 27, 2021

@codificat: Reopened this issue.

In response to this:

this was auto-closed 1 month after reopening. I believe the intention was:
/reopen
/lifecycle frozen
feel free to correct if that's not the case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 27, 2021
@codificat
Copy link
Member

/sig observability
/triage accepted

@sesheta sesheta added sig/observability Categorizes an issue or PR as relevant to SIG Observability triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 29, 2022
@harshad16 harshad16 moved this to Backlog in SIG-Observability Sep 22, 2022
@codificat codificat moved this to 📋 Backlog in Planning Board Sep 26, 2022
@VannTen
Copy link
Member

VannTen commented Oct 28, 2022

Following the discussion in SIG meeting yesterday.

For metrics persistence, would we have the option to retain metrics longer ? (-> and have public dashboard / dashboard snapshots). I know Thanos can store metrics for long-term storage into object storage for example (S3), could that be an option ?

@goern
Copy link
Member

goern commented Oct 31, 2022

revisiting the existing dashboards, and esp have the data stored in thanos, seems to be the right thing to do.

@goern goern removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/observability Categorizes an issue or PR as relevant to SIG Observability triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning Board
Status: 📋 Backlog
SIG-Observability
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@goern @codificat @VannTen @harshad16 @pacospace @sesheta