Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide admin password for PostgreSQL database #725

Closed
fridex opened this issue Jan 7, 2021 · 5 comments
Closed

Provide admin password for PostgreSQL database #725

fridex opened this issue Jan 7, 2021 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@fridex
Copy link
Contributor

fridex commented Jan 7, 2021

Is your feature request related to a problem? Please describe.

As shown in the example in [1], we need to have the admin password for PostgreSQL databases. Currently, we do not setup the admin password. This could be accomplished by providing POSTGRESQL_ADMIN_PASSWORD environment variable to the postgresql container image as described in [2]

Describe the solution you'd like

Add environment variable for configuring PostgreSQL password as described in [1].

Describe alternatives you've considered

There are no alternatives on how to enable the extension. The admin password is needed to enable the extension.

Additional context

[1] sclorg/postgresql-container#394
[2] https://docs.openshift.com/enterprise/3.1/using_images/db_images/postgresql.html#postgresql-changing-passwords

@harshad16
Copy link
Member

Thanks, @fridex for the detailed description.
will enable this feature on the test cluster.

@harshad16
Copy link
Member

The feature is enabled in Test Cluster,
what all components need access to the admin password? based on that we would update the password accessibility to the components.
@KPostOffice

@harshad16
Copy link
Member

Based on the discussion with @KPostOffice

Following actions would be considered

  1. CREATE EXTENSION amcheck
  2. QUERY USING amcheck

Step (1) one would be done on the cluster setup or db setup.
Metrics Exporter would be used for step (2), with a metric that we can use to alert when DB corruption is detected.

Next Step:

Test the amcheck in the test environment with metrics-exporter.
If successful, replicate on all the databases in each environment.

@goern
Copy link
Member

goern commented Apr 16, 2021

@KPostOffice @harshad16 can we close this?

@harshad16
Copy link
Member

we have change the privileges instead of using the admin user.
with the change of user to super user , the admin password setup is not required.
we have include it in test for future extension enablement and testing.
More details here: thoth-station/storages#2250 (comment)
Also document this with a doc.

closing this issue.

@harshad16 harshad16 moved this to Completed in SIG-DevSecOps Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants