From 3149e38ceb0d79ef454fdea40a7900bf3d19ba46 Mon Sep 17 00:00:00 2001 From: Spyros Date: Fri, 29 May 2020 12:33:36 +0100 Subject: [PATCH] extends plese and proto fixes to prs that were inflight when these fixes landed (#33) --- consumers/slack/BUILD | 6 +++--- consumers/slack/types/BUILD | 2 +- consumers/slack/types/full-document.go | 2 +- consumers/slack/utils/BUILD | 9 +++++---- consumers/slack/utils/utils.go | 2 +- consumers/slack/utils/utils_test.go | 2 +- producers/dependency_check/BUILD | 2 +- producers/pipsafety/BUILD | 2 +- producers/pipsafety/types/safety-issue.go | 2 +- 9 files changed, 15 insertions(+), 14 deletions(-) diff --git a/consumers/slack/BUILD b/consumers/slack/BUILD index 88df249..e4f57c2 100644 --- a/consumers/slack/BUILD +++ b/consumers/slack/BUILD @@ -1,4 +1,4 @@ -subinclude("@pleasings//docker") +subinclude("@third_party/subrepos/pleasings//docker") go_binary( @@ -9,8 +9,8 @@ go_binary( deps = [ "//consumers", "//consumers/slack/utils:utils", - "//pkg/genproto/v1", - "//third_party/go:golang_protobuf", + "//api/proto:v1", + "//third_party/go:protobuf", ], ) diff --git a/consumers/slack/types/BUILD b/consumers/slack/types/BUILD index fc473bb..a3c3b04 100644 --- a/consumers/slack/types/BUILD +++ b/consumers/slack/types/BUILD @@ -7,6 +7,6 @@ go_library( visibility = [ "//consumers/slack/...", ], - deps = ["//pkg/genproto/v1",] + deps = ["//api/proto:v1",] ) diff --git a/consumers/slack/types/full-document.go b/consumers/slack/types/full-document.go index b591c38..4b3be59 100644 --- a/consumers/slack/types/full-document.go +++ b/consumers/slack/types/full-document.go @@ -3,7 +3,7 @@ package types import ( "time" - v1 "github.com/thought-machine/dracon/pkg/genproto/v1" + v1 "api/proto/v1" ) type FullDocument struct { diff --git a/consumers/slack/utils/BUILD b/consumers/slack/utils/BUILD index d38f876..db3ed0e 100644 --- a/consumers/slack/utils/BUILD +++ b/consumers/slack/utils/BUILD @@ -7,9 +7,10 @@ go_library( visibility = [ "//consumers/slack/...", ], - deps = ["//pkg/genproto/v1", + deps = ["//api/proto:v1", "//consumers/slack/types", - "//third_party/go:golang_protobuf",] + "//third_party/go:protobuf", + ] ) go_test( @@ -21,9 +22,9 @@ go_test( deps = [ ":utils", "//consumers", - "//pkg/genproto/v1", + "//api/proto:v1", "//third_party/go:gogo_protobuf", - "//third_party/go:golang_protobuf", + "//third_party/go:protobuf", "//third_party/go:stretchr_testify", ], ) diff --git a/consumers/slack/utils/utils.go b/consumers/slack/utils/utils.go index a1e12b5..2c1309a 100644 --- a/consumers/slack/utils/utils.go +++ b/consumers/slack/utils/utils.go @@ -10,7 +10,7 @@ import ( "time" "github.com/golang/protobuf/ptypes" - v1 "github.com/thought-machine/dracon/pkg/genproto/v1" + "api/proto/v1" ) func push(b string, webhook string) error { diff --git a/consumers/slack/utils/utils_test.go b/consumers/slack/utils/utils_test.go index aed0bf4..77e612f 100644 --- a/consumers/slack/utils/utils_test.go +++ b/consumers/slack/utils/utils_test.go @@ -11,7 +11,7 @@ import ( "github.com/golang/protobuf/ptypes" "github.com/stretchr/testify/assert" - v1 "github.com/thought-machine/dracon/pkg/genproto/v1" + "api/proto/v1" ) //TODO tests: count* get* diff --git a/producers/dependency_check/BUILD b/producers/dependency_check/BUILD index e3735c7..4e53146 100644 --- a/producers/dependency_check/BUILD +++ b/producers/dependency_check/BUILD @@ -1,4 +1,4 @@ -subinclude("@pleasings//docker") +subinclude("@third_party/subrepos/pleasings//docker") go_binary( name = "dependency_check", diff --git a/producers/pipsafety/BUILD b/producers/pipsafety/BUILD index fef9102..ab7830e 100644 --- a/producers/pipsafety/BUILD +++ b/producers/pipsafety/BUILD @@ -1,4 +1,4 @@ -subinclude("@pleasings//docker") +subinclude("@third_party/subrepos/pleasings//docker") go_binary( name = "pipsafety", diff --git a/producers/pipsafety/types/safety-issue.go b/producers/pipsafety/types/safety-issue.go index 81b7e54..7c2d5cd 100644 --- a/producers/pipsafety/types/safety-issue.go +++ b/producers/pipsafety/types/safety-issue.go @@ -23,6 +23,6 @@ func (i *SafetyIssue) UnmarshalJSON(data []byte) error { i.Name, _ = v[0].(string) i.VersionConstraint, _ = v[1].(string) i.CurrentVersion, _ = v[2].(string) - i.Descriptionm, _ = v[3].(string) + i.Description, _ = v[3].(string) return nil }