Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standard errors #474

Open
sarahraqueld opened this issue May 24, 2024 · 1 comment · May be fixed by #482
Open

Fix standard errors #474

sarahraqueld opened this issue May 24, 2024 · 1 comment · May be fixed by #482
Assignees

Comments

@sarahraqueld
Copy link
Contributor

On Github actions:

standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
spec/support/macros/define_constant.rb:10:40: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
spec/support/macros/define_constant.rb:11:52: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
spec/support/macros/define_constant.rb:20:32: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
spec/support/macros/define_constant.rb:25:43: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
standard: Run rake standard:fix to fix up to 4 problems.

https://github.com/thoughtbot/factory_bot_rails/actions/runs/9221161554/job/25369617245?pr=468

@sarahraqueld sarahraqueld self-assigned this May 24, 2024
@smaboshe
Copy link
Contributor

Nice catch!

Would it be worth adding a Standard check to our GitHub Actions?

@sarahraqueld sarahraqueld linked a pull request Jul 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants