From ec03d1a0e2d0c9a70e67ee5a62b575a5474aa075 Mon Sep 17 00:00:00 2001 From: Steve Polito Date: Mon, 25 Mar 2024 05:20:55 -0400 Subject: [PATCH] Lint Generator: No longer fix violations after invocation Supports #1152 We found that we needed to run this generator last in `suspenders:install:web` to ensure any potential violation was resolved. Instead, we'll just make that the responsibility of `suspenders:install:web`. --- lib/generators/suspenders/lint_generator.rb | 7 ------- test/generators/suspenders/lint_generator_test.rb | 9 --------- 2 files changed, 16 deletions(-) diff --git a/lib/generators/suspenders/lint_generator.rb b/lib/generators/suspenders/lint_generator.rb index af81b5731..96aa0533f 100644 --- a/lib/generators/suspenders/lint_generator.rb +++ b/lib/generators/suspenders/lint_generator.rb @@ -55,13 +55,6 @@ def update_package_json File.write package_json, JSON.pretty_generate(json) end - # This needs to be the last method definition to ensure everything is - # properly configured - def fix_violations - run "yarn run fix:prettier" - run "bundle exec rake standard:fix_unsafely" - end - private def package_json diff --git a/test/generators/suspenders/lint_generator_test.rb b/test/generators/suspenders/lint_generator_test.rb index 7bc82f6ec..13b2608a2 100644 --- a/test/generators/suspenders/lint_generator_test.rb +++ b/test/generators/suspenders/lint_generator_test.rb @@ -248,15 +248,6 @@ class LintGeneratorTest < Rails::Generators::TestCase assert_equal desc, generator_class.desc end - test "fixes violations" do - capture(:stderr) do - output = run_generator - - assert_match(/yarn run fix:prettier/, output) - assert_match(/bundle exec rake standard:fix_unsafely/, output) - end - end - private def prepare_destination