Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sprockets #1117

Closed
stevepolitodesign opened this issue Dec 15, 2022 · 3 comments
Closed

Remove sprockets #1117

stevepolitodesign opened this issue Dec 15, 2022 · 3 comments

Comments

@stevepolitodesign
Copy link
Contributor

I don't think we need sprockets anymore, but the tests for an API-only app fail when it's removed. For now, I've done the following:

<% if options[:api] %>
gem "sprockets", "< 4"
<% end %>
@stevepolitodesign
Copy link
Contributor Author

stevepolitodesign commented Dec 15, 2022 •
edited
Loading

Here's the error I get when I run suspenders some_app --api

CleanShot 2022-12-15 at 10 55 44@2x

I can confirm that a standard app generated with suspenders suspenders some_app does create app/assets/config/manifest.js. So, do API only applications still need this file?

@stevepolitodesign stevepolitodesign mentioned this issue Dec 15, 2022
Merged
6 tasks
stevepolitodesign added a commit that referenced this issue Dec 15, 2022
@stevepolitodesign @emilford
Remove deprecated CSS tooling. Introduce postcss. (#1113)
5c27b46 
Remove obsolete CSS tooling such as bourbon in favor of postcss. This change requires us to use cssbundling-rails and jsbundling-rails.

We needed to keep `sprockets` to prevent existing tests from failing when the app is generated in API only mode, but #1117 will explore a solution.

Co-authored-by: Eric Milford <[email protected]>
@stevepolitodesign
Copy link
Contributor Author

https://github.com/rails/sprockets/blob/070fc01947c111d35bb4c836e9bb71962a8e0595/UPGRADING.md#manifestjs

@stevepolitodesign
Copy link
Contributor Author

Closed by #1135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevepolitodesign