-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Support multiple reporters with different options #790
Comments
In general, it's a good idea. And as long as the existing format is still supported, that shouldn't affect existing users. Not too happy with "reporters" below "report". We could do it without an additional key. By default, each immediate child (e.g. report:
text: # Still have these for inheritance
details: true
footer: true
line_length: 75
minimal: false
html:
diff: unified
email:
- enabled: true
from: [email protected]
to: [email protected]
method: sendmail
tags: tag1
- enabled: true
from: [email protected]
to: [email protected]
method: sendmail
tags: tag2
html: true
stdout:
color: true
enabled: true
telegram: # Still support dict format
bot_token: ''
chat_id: ''
enabled: false This would probably be the least intrusive (no new keys), and should be super simple to check (if the immediate child is a dict, treat it as a single config, otherwise if it's a list, treat it as list of multiple configs). Certain shared/superclass configs (e.g. |
I think it's either make a compromise like either of our suggestions, or create a V2 config file format and redesign it with the new requirements in mind, supporting both formats for now. I would probably go with a compromise and your option looks good. I'll propose an implementation based on the tagging at some point, when I next get a chance to look at it. |
Great, I like the compromise (backwards compatible) variant better, because it means less disruption for existing users. And maybe you can split the possible PRs into two, once that adds multiple reporter configs, and then after that's been merged, a separate on that adds tagging on top (or I guess tagging could be done first, as these are mostly independent?). |
I did tagging first because I already had that PR in flight :) |
WIP on this, for after tags are merged in: https://github.com/thp/urlwatch/compare/master...Jamstah:multiple-reporters?expand=1 |
Tags is now merged if you want to tackle this, too. |
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <[email protected]>
Interested in thoughts of this style of config
The text was updated successfully, but these errors were encountered: