Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolating executor into its own code #55

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Isolating executor into its own code #55

merged 4 commits into from
Dec 12, 2021

Conversation

andreespirela
Copy link
Collaborator

@andreespirela andreespirela commented Dec 12, 2021 •
edited
Loading

Close #54

@andreespirela andreespirela linked an issue Dec 12, 2021 that may be closed by this pull request
Isolate executor #54
Closed
andreespirela
andreespirela commented Dec 12, 2021
View reviewed changes
crates/executor/executor.rs

#[tokio::test]
pub async fn test_executor_js() {
let init_state = serde_json::json!({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@littledivy needed for #47 unit testing. In general, this will help a lot. Be mindful of this abstraction, not sure if it's needed for WASM

@andreespirela andreespirela merged commit 2f33652 into main Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Isolate executor
1 participant
@andreespirela