Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing WebXRManager exports in r167 #1139

Closed
asyncore opened this issue Aug 5, 2024 · 1 comment · Fixed by #1140
Closed

Missing WebXRManager exports in r167 #1139

asyncore opened this issue Aug 5, 2024 · 1 comment · Fixed by #1140

Comments

@asyncore
Copy link
Contributor

asyncore commented Aug 5, 2024

PR #1079 seems to have removed the following export from three.d.ts

export * from "./renderers/webxr/WebXRManager.js";

Which causes missing THREE.WebXRArrayCamera and THREE.WebXRManager symbol errors in our codebase.

Do you know if the change was intentional?

@Methuselah96
Copy link
Contributor

Methuselah96 commented Aug 5, 2024

It was unintentional. The goal of that PR was to match the exports of three.js in order to avoid exporting more JS values from the main entry-point than three.js does, however I missed a few type-only exports that should still be exported.

#1131 adds back some of the other type exports I missed. I'll work on creating a PR to add these back as well, or feel free to do it yourself if you beat me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants