EventDispatcher typing consistency

[s-rigaud]

The EventDispatcher only has one method definition for dispatchEvent which is strict.

three-ts-types/types/three/src/core/EventDispatcher.d.ts

Line 84 in c8cea80

dispatchEvent<T extends Extract<keyof TEventMap, string>>(event: BaseEvent<T> & TEventMap[T]): void;

---

While there are multiple method definitions for addEventListener which make the typing a bit loose.

three-ts-types/types/three/src/core/EventDispatcher.d.ts

Lines 52 to 55 in c8cea80

	addEventListener<T extends Extract<keyof TEventMap, string>>(
	type: T,
	listener: EventListener<TEventMap[T], T, this>,
	): void;

three-ts-types/types/three/src/core/EventDispatcher.d.ts

Line 56 in c8cea80

addEventListener<T extends string>(type: T, listener: EventListener<{}, T, this>): void;

---

I don't understand why addEventListener is loose when it directly depends over dispatchEvent which is strict. Shouldn't the loosest implementation based over regular string be removed ? It would raise error when listening to none defined event and thus be more type safe 🤔
It will be especially useful when creating custom controls inheriting from EventDispatcher.

[Methuselah96]

Good question! Those may have been left in by mistake in #369. I'm experimenting with removing them in #1145, but it does seem to break some tests, so I need to look into that some more.

[Methuselah96]

I was able to fix all the tests fairly easily, and they seemed like positive changes. 🎉 Let's give this a go!

Blocked by an error in another package's tests, will need to fix that first.