From f416adc493879e4db76b9ff17250887f3fdfeb09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Y=C3=B6net?= <3523671+Yonet@users.noreply.github.com> Date: Sat, 1 Jul 2023 15:25:03 +0300 Subject: [PATCH 1/4] Add XRButton.d.ts --- types/three/examples/jsm/webxr/XRButton.d.ts | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 types/three/examples/jsm/webxr/XRButton.d.ts diff --git a/types/three/examples/jsm/webxr/XRButton.d.ts b/types/three/examples/jsm/webxr/XRButton.d.ts new file mode 100644 index 000000000..66e7c2657 --- /dev/null +++ b/types/three/examples/jsm/webxr/XRButton.d.ts @@ -0,0 +1,5 @@ +import { WebGLRenderer } from '../../../src/Three'; + +export class XRButton { + static createButton(renderer: WebGLRenderer): HTMLElement; +} From 08a6ae82297f34790c4b2f79a7e672647e940e8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Y=C3=B6net?= <3523671+Yonet@users.noreply.github.com> Date: Sat, 1 Jul 2023 13:16:24 +0000 Subject: [PATCH 2/4] Update webxr-vr-cubes to use XRButton and rename to WebXR--cubes --- .../{webxr-vr-cube.ts => webxr-cube.ts} | 26 +------------------ types/three/tsconfig.json | 2 +- 2 files changed, 2 insertions(+), 26 deletions(-) rename types/three/test/integration/{webxr-vr-cube.ts => webxr-cube.ts} (71%) diff --git a/types/three/test/integration/webxr-vr-cube.ts b/types/three/test/integration/webxr-cube.ts similarity index 71% rename from types/three/test/integration/webxr-vr-cube.ts rename to types/three/test/integration/webxr-cube.ts index 60116996a..efcc0b442 100644 --- a/types/three/test/integration/webxr-vr-cube.ts +++ b/types/three/test/integration/webxr-cube.ts @@ -1,6 +1,7 @@ // A simple WebXR VR example that just shows a cube. import * as THREE from 'three'; +import { XRButton } from 'three/examples/jsm/webxr/XRButton'; const container = document.createElement('div'); @@ -8,7 +9,6 @@ const renderer = new THREE.WebGLRenderer({ antialias: true }); const camera = new THREE.PerspectiveCamera(50, 2, 0.1, 10); const scene = new THREE.Scene(); -const vrButton = document.createElement('button'); let currentSession: XRSession | null = null; let mesh: THREE.Mesh; @@ -18,8 +18,6 @@ async function onSessionStarted(session: XRSession): Promise { session.addEventListener('end', onSessionEnded); await renderer.xr.setSession(session); - vrButton.innerText = 'Exit VR'; - currentSession = session; } @@ -27,11 +25,8 @@ async function onSessionEnded(): Promise { if (currentSession == null) { return; } - currentSession.removeEventListener('end', onSessionEnded); await renderer.xr.setSession(null); - vrButton.innerText = 'Enter VR'; - currentSession = null; } @@ -53,7 +48,6 @@ function init(): void { renderer.setPixelRatio(window.devicePixelRatio); renderer.setSize(300, 150); - renderer.outputEncoding = THREE.sRGBEncoding; renderer.xr.enabled = true; container.appendChild(renderer.domElement); @@ -70,24 +64,6 @@ function init(): void { directionalLight.position.set(1, 1, 1).normalize(); scene.add(directionalLight); - checkVRSupport().then(xr => { - if (xr) { - vrButton.innerText = 'Enter VR'; - - vrButton.addEventListener('click', async () => { - if (currentSession == null) { - const sessionInit = { optionalFeatures: ['local-floor', 'bounded-floor'] }; - const session = await xr.requestSession('immersive-vr', sessionInit); - await onSessionStarted(session); - } - }); - } else { - vrButton.innerText = 'VR Not Supported'; - } - - container.appendChild(vrButton); - }); - renderer.setAnimationLoop(() => { mesh.rotation.x += 0.005; mesh.rotation.y += 0.01; diff --git a/types/three/tsconfig.json b/types/three/tsconfig.json index 60d973d16..79bff73ff 100644 --- a/types/three/tsconfig.json +++ b/types/three/tsconfig.json @@ -78,7 +78,7 @@ "test/integration/three-examples/webgl_shadowmap_vsm.ts", "test/integration/three-examples/webxr_ar_lighting.ts", "test/integration/three-examples/webxr_vr_handinput_cubes.ts", - "test/integration/webxr-vr-cube.ts", + "test/integration/webxr-cube.ts", "test/unit/examples/jsm/exporters/PLYExporter.ts", "test/unit/examples/jsm/exporters/STLExporter.ts", "test/unit/examples/jsm/helpers/ViewHelper.ts", From 38a30ba5fc77b868678c020abcf0f075a95ee1eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Y=C3=B6net?= <3523671+Yonet@users.noreply.github.com> Date: Sun, 2 Jul 2023 15:39:18 +0000 Subject: [PATCH 3/4] add(webxr): XRButton type --- .all-contributorsrc | 762 +------------------ README.md | 7 +- types/three/examples/jsm/webxr/XRButton.d.ts | 1 + 3 files changed, 6 insertions(+), 764 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 2c39b59d9..417b7b537 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1,761 +1 @@ -{ - "projectName": "three-ts-types", - "projectOwner": "three-types", - "repoType": "github", - "repoHost": "https://github.com", - "files": [ - "README.md" - ], - "imageSize": 100, - "commit": false, - "commitConvention": "none", - "contributors": [ - { - "login": "joshuaellis", - "name": "Josh", - "avatar_url": "https://avatars.githubusercontent.com/u/37798644?v=4", - "profile": "https://github.com/joshuaellis", - "contributions": [ - "question", - "bug", - "code", - "doc", - "ideas", - "maintenance", - "review", - "test" - ] - }, - { - "login": "Methuselah96", - "name": "Nathan Bierema", - "avatar_url": "https://avatars.githubusercontent.com/u/693755?v=4", - "profile": "https://github.com/Methuselah96", - "contributions": [ - "question", - "bug", - "code", - "doc", - "ideas", - "infra", - "maintenance", - "review", - "test" - ] - }, - { - "login": "Mugen87", - "name": "Michael Herzog", - "avatar_url": "https://avatars.githubusercontent.com/u/12612165?v=4", - "profile": "https://human-interactive.org", - "contributions": [ - "code" - ] - }, - { - "login": "CodyJasonBennett", - "name": "Cody Bennett", - "avatar_url": "https://avatars.githubusercontent.com/u/23324155?v=4", - "profile": "https://github.com/CodyJasonBennett", - "contributions": [ - "code" - ] - }, - { - "login": "0b5vr", - "name": "0b5vr", - "avatar_url": "https://avatars.githubusercontent.com/u/7824814?v=4", - "profile": "http://0b5vr.github.io/", - "contributions": [ - "code", - "test", - "maintenance", - "review", - "bug" - ] - }, - { - "login": "marquizzo", - "name": "Marquizzo", - "avatar_url": "https://avatars.githubusercontent.com/u/7864858?v=4", - "profile": "https://stackoverflow.com/users/2608515/marquizzo", - "contributions": [ - "code" - ] - }, - { - "login": "khum08", - "name": "Yuanzk", - "avatar_url": "https://avatars.githubusercontent.com/u/32336026?v=4", - "profile": "https://github.com/khum08", - "contributions": [ - "code" - ] - }, - { - "login": "elisee", - "name": "Elisée Maurer", - "avatar_url": "https://avatars.githubusercontent.com/u/446986?v=4", - "profile": "http://sparklinlabs.com/", - "contributions": [ - "code" - ] - }, - { - "login": "soadzoor", - "name": "soadzoor", - "avatar_url": "https://avatars.githubusercontent.com/u/10392261?v=4", - "profile": "https://github.com/soadzoor", - "contributions": [ - "code" - ] - }, - { - "login": "rinsuki", - "name": "rinsuki", - "avatar_url": "https://avatars.githubusercontent.com/u/6533808?v=4", - "profile": "https://github.com/rinsuki", - "contributions": [ - "code" - ] - }, - { - "login": "efokschaner", - "name": "efokschaner", - "avatar_url": "https://avatars.githubusercontent.com/u/1409112?v=4", - "profile": "https://github.com/efokschaner", - "contributions": [ - "code" - ] - }, - { - "login": "Jhuni0123", - "name": "Jonghun Park", - "avatar_url": "https://avatars.githubusercontent.com/u/16764073?v=4", - "profile": "https://github.com/Jhuni0123", - "contributions": [ - "code" - ] - }, - { - "login": "sjpt", - "name": "sjpt", - "avatar_url": "https://avatars.githubusercontent.com/u/4954988?v=4", - "profile": "https://github.com/sjpt", - "contributions": [ - "code" - ] - }, - { - "login": "Michsior14", - "name": "Michał Mrozek", - "avatar_url": "https://avatars.githubusercontent.com/u/1410035?v=4", - "profile": "https://github.com/Michsior14", - "contributions": [ - "code" - ] - }, - { - "login": "puxiao", - "name": "puxiao", - "avatar_url": "https://avatars.githubusercontent.com/u/3401635?v=4", - "profile": "https://puxiao.com", - "contributions": [ - "code" - ] - }, - { - "login": "ycw", - "name": "ycw", - "avatar_url": "https://avatars.githubusercontent.com/u/1063018?v=4", - "profile": "https://github.com/ycw", - "contributions": [ - "code" - ] - }, - { - "login": "Jazcash", - "name": "Jazcash", - "avatar_url": "https://avatars.githubusercontent.com/u/1434248?v=4", - "profile": "https://github.com/Jazcash", - "contributions": [ - "code" - ] - }, - { - "login": "bjornstar", - "name": "Bjorn Stromberg", - "avatar_url": "https://avatars.githubusercontent.com/u/20630?v=4", - "profile": "https://bjornstar.com/", - "contributions": [ - "code" - ] - }, - { - "login": "happy-turtle", - "name": "HappyTurtle", - "avatar_url": "https://avatars.githubusercontent.com/u/18415215?v=4", - "profile": "https://github.com/happy-turtle", - "contributions": [ - "code" - ] - }, - { - "login": "shuta13", - "name": "Shuta Hirai", - "avatar_url": "https://avatars.githubusercontent.com/u/38882716?v=4", - "profile": "https://studio.did0es.me/", - "contributions": [ - "code" - ] - }, - { - "login": "servinlp", - "name": "Servin Nissen", - "avatar_url": "https://avatars.githubusercontent.com/u/7222029?v=4", - "profile": "https://github.com/servinlp", - "contributions": [ - "code" - ] - }, - { - "login": "benpigchu", - "name": "Ben \"Pig\" Chu", - "avatar_url": "https://avatars.githubusercontent.com/u/9023067?v=4", - "profile": "https://benpigchu.com/", - "contributions": [ - "code" - ] - }, - { - "login": "woo-cie", - "name": "Makoto Yamada", - "avatar_url": "https://avatars.githubusercontent.com/u/24642989?v=4", - "profile": "https://github.com/woo-cie", - "contributions": [ - "code" - ] - }, - { - "login": "schwyzl", - "name": "schwyzl", - "avatar_url": "https://avatars.githubusercontent.com/u/1556979?v=4", - "profile": "https://github.com/schwyzl", - "contributions": [ - "code" - ] - }, - { - "login": "Degubi", - "name": "Degubi", - "avatar_url": "https://avatars.githubusercontent.com/u/13366932?v=4", - "profile": "https://github.com/Degubi", - "contributions": [ - "code" - ] - }, - { - "login": "WCWedin", - "name": "Ibby Wedin", - "avatar_url": "https://avatars.githubusercontent.com/u/110730?v=4", - "profile": "https://github.com/WCWedin", - "contributions": [ - "code" - ] - }, - { - "login": "dbuck", - "name": "dbuck", - "avatar_url": "https://avatars.githubusercontent.com/u/983807?v=4", - "profile": "https://github.com/dbuck", - "contributions": [ - "code" - ] - }, - { - "login": "robertlong", - "name": "Robert Long", - "avatar_url": "https://avatars.githubusercontent.com/u/1753624?v=4", - "profile": "https://github.com/robertlong", - "contributions": [ - "code" - ] - }, - { - "login": "XertroV", - "name": "Max Kaye", - "avatar_url": "https://avatars.githubusercontent.com/u/1046448?v=4", - "profile": "https://xk.io/", - "contributions": [ - "doc" - ] - }, - { - "login": "LauferAlex", - "name": "Alejandro Laufer", - "avatar_url": "https://avatars.githubusercontent.com/u/86115165?v=4", - "profile": "https://github.com/LauferAlex", - "contributions": [ - "bug", - "code" - ] - }, - { - "login": "gsimone", - "name": "Gianmarco", - "avatar_url": "https://avatars.githubusercontent.com/u/1862172?v=4", - "profile": "https://twitter.com/ggsimm", - "contributions": [ - "code" - ] - }, - { - "login": "DavidPeicho", - "name": "David Peicho", - "avatar_url": "https://avatars.githubusercontent.com/u/8783766?v=4", - "profile": "https://davidpeicho.github.io/", - "contributions": [ - "code" - ] - }, - { - "login": "trusktr", - "name": "Joe Pea", - "avatar_url": "https://avatars.githubusercontent.com/u/297678?v=4", - "profile": "https://github.com/trusktr", - "contributions": [ - "code" - ] - }, - { - "login": "subhankar-trisetra", - "name": "Subhankar Pal", - "avatar_url": "https://avatars.githubusercontent.com/u/98544661?v=4", - "profile": "https://subho57.github.io", - "contributions": [ - "code" - ] - }, - { - "login": "capnmidnight", - "name": "Sean T. McBeth", - "avatar_url": "https://avatars.githubusercontent.com/u/298046?v=4", - "profile": "http://www.seanmcbeth.com/", - "contributions": [ - "code" - ] - }, - { - "login": "atulrnt", - "name": "Arthur LAURENT", - "avatar_url": "https://avatars.githubusercontent.com/u/894203?v=4", - "profile": "https://github.com/atulrnt", - "contributions": [ - "code" - ] - }, - { - "login": "serenayl", - "name": "Serena Li", - "avatar_url": "https://avatars.githubusercontent.com/u/12814119?v=4", - "profile": "https://github.com/serenayl", - "contributions": [ - "code" - ] - }, - { - "login": "cosformula", - "name": "cosformula", - "avatar_url": "https://avatars.githubusercontent.com/u/18232501?v=4", - "profile": "https://github.com/cosformula", - "contributions": [ - "code" - ] - }, - { - "login": "miko3k", - "name": "Peter Hanula", - "avatar_url": "https://avatars.githubusercontent.com/u/8658482?v=4", - "profile": "https://github.com/miko3k", - "contributions": [ - "code" - ] - }, - { - "login": "MysteryBlokHed", - "name": "Adam Thompson-Sharpe", - "avatar_url": "https://avatars.githubusercontent.com/u/13910387?v=4", - "profile": "https://github.com/MysteryBlokHed", - "contributions": [ - "code" - ] - }, - { - "login": "noname0310", - "name": "noname", - "avatar_url": "https://avatars.githubusercontent.com/u/48761044?v=4", - "profile": "https://www.youtube.com/c/noname0310", - "contributions": [ - "code" - ] - }, - { - "login": "grschafer", - "name": "Greg Schafer", - "avatar_url": "https://avatars.githubusercontent.com/u/694225?v=4", - "profile": "https://github.com/grschafer", - "contributions": [ - "code" - ] - }, - { - "login": "SuperSodaSea", - "name": "SuperSodaSea", - "avatar_url": "https://avatars.githubusercontent.com/u/8724868?v=4", - "profile": "https://github.com/SuperSodaSea", - "contributions": [ - "code" - ] - }, - { - "login": "mattrossman", - "name": "Matt Rossman", - "avatar_url": "https://avatars.githubusercontent.com/u/22670878?v=4", - "profile": "https://github.com/mattrossman", - "contributions": [ - "code" - ] - }, - { - "login": "alexpineda", - "name": "Alex Pineda", - "avatar_url": "https://avatars.githubusercontent.com/u/586716?v=4", - "profile": "https://github.com/imbateam-gg/titan-reactor", - "contributions": [ - "code" - ] - }, - { - "login": "Draichi", - "name": "Lucas", - "avatar_url": "https://avatars.githubusercontent.com/u/19378148?v=4", - "profile": "https://draichiboard.vercel.app/", - "contributions": [ - "doc" - ] - }, - { - "login": "mz8i", - "name": "Maciej Ziarkowski", - "avatar_url": "https://avatars.githubusercontent.com/u/36160844?v=4", - "profile": "https://github.com/mz8i", - "contributions": [ - "code" - ] - }, - { - "login": "Suprhimp", - "name": "Suprhimp", - "avatar_url": "https://avatars.githubusercontent.com/u/73486185?v=4", - "profile": "https://github.com/Suprhimp", - "contributions": [ - "code" - ] - }, - { - "login": "Trinovantes", - "name": "Stephen Li", - "avatar_url": "https://avatars.githubusercontent.com/u/458691?v=4", - "profile": "https://www.stephenli.ca/", - "contributions": [ - "code" - ] - }, - { - "login": "autonomobil", - "name": "Moritz Cremer", - "avatar_url": "https://avatars.githubusercontent.com/u/31781343?s=96&v=4", - "profile": "https://github.com/autonomobil", - "contributions": [ - "code" - ] - }, - { - "login": "LuchoTurtle", - "name": "LuchoTurtle", - "avatar_url": "https://avatars.githubusercontent.com/u/17494745?v=4", - "profile": "https://github.com/LuchoTurtle", - "contributions": [ - "code" - ] - }, - { - "login": "marwie", - "name": "Marcel Wiessler", - "avatar_url": "https://avatars.githubusercontent.com/u/5083203?v=4", - "profile": "https://www.needle.tools", - "contributions": [ - "code" - ] - }, - { - "login": "JoshStern", - "name": "Josh Stern", - "avatar_url": "https://avatars.githubusercontent.com/u/10948202?v=4", - "profile": "https://github.com/JoshStern", - "contributions": [ - "code" - ] - }, - { - "login": "rotu", - "name": "Dan Rose", - "avatar_url": "https://avatars.githubusercontent.com/u/119948?v=4", - "profile": "https://github.com/rotu", - "contributions": [ - "code" - ] - }, - { - "login": "gegoggigog", - "name": "Dan Dolonius", - "avatar_url": "https://avatars.githubusercontent.com/u/1716001?v=4", - "profile": "https://github.com/gegoggigog", - "contributions": [ - "code" - ] - }, - { - "login": "Hoodgail", - "name": "Benjamin", - "avatar_url": "https://avatars.githubusercontent.com/u/45743294?v=4", - "profile": "https://hoodgail.com/", - "contributions": [ - "code" - ] - }, - { - "login": "agviegas", - "name": "Antonio González Viegas", - "avatar_url": "https://avatars.githubusercontent.com/u/56475338?v=4", - "profile": "https://www.linkedin.com/in/antonio-gonz%C3%A1lez-viegas-8b2326151/", - "contributions": [ - "code" - ] - }, - { - "login": "donmccurdy", - "name": "Don McCurdy", - "avatar_url": "https://avatars.githubusercontent.com/u/1848368?v=4", - "profile": "https://www.donmccurdy.com/", - "contributions": [ - "code" - ] - }, - { - "login": "xawill", - "name": "Xavier Willemin", - "avatar_url": "https://avatars.githubusercontent.com/u/2658206?v=4", - "profile": "https://github.com/xawill", - "contributions": [ - "code" - ] - }, - { - "login": "r00ster91", - "name": "zooster", - "avatar_url": "https://avatars.githubusercontent.com/u/35064754?v=4", - "profile": "https://github.com/r00ster91", - "contributions": [ - "code" - ] - }, - { - "login": "andersonleite", - "name": "Anderson Leite", - "avatar_url": "https://avatars.githubusercontent.com/u/52427?v=4", - "profile": "https://github.com/andersonleite", - "contributions": [ - "code" - ] - }, - { - "login": "frading", - "name": "Guillaume Fradin", - "avatar_url": "https://avatars.githubusercontent.com/u/59701?v=4", - "profile": "https://polygonjs.com/", - "contributions": [ - "code" - ] - }, - { - "login": "Heaust-ops", - "name": "Heaust Azure", - "avatar_url": "https://avatars.githubusercontent.com/u/54670936?v=4", - "profile": "https://github.com/Heaust-ops", - "contributions": [ - "code" - ] - }, - { - "login": "Gallahron", - "name": "Joe Tipping", - "avatar_url": "https://avatars.githubusercontent.com/u/39060404?v=4", - "profile": "http://www.joemo.co.uk/", - "contributions": [ - "code" - ] - }, - { - "login": "lgarron", - "name": "Lucas Garron", - "avatar_url": "https://avatars.githubusercontent.com/u/248078?v=4", - "profile": "https://garron.net/", - "contributions": [ - "code" - ] - }, - { - "login": "maccesch", - "name": "Marc-Stefan Cassola", - "avatar_url": "https://avatars.githubusercontent.com/u/380881?v=4", - "profile": "https://github.com/maccesch", - "contributions": [ - "code" - ] - }, - { - "login": "peterblazejewicz", - "name": "Piotr Błażejewicz (Peter Blazejewicz)", - "avatar_url": "https://avatars.githubusercontent.com/u/14539?v=4", - "profile": "http://www.linkedin.com/in/peterblazejewicz", - "contributions": [ - "code" - ] - }, - { - "login": "Vikontte", - "name": "Victoria Shadrina", - "avatar_url": "https://avatars.githubusercontent.com/u/18411533?v=4", - "profile": "https://github.com/Vikontte", - "contributions": [ - "code" - ] - }, - { - "login": "willstott101", - "name": "Will Stott", - "avatar_url": "https://avatars.githubusercontent.com/u/335152?v=4", - "profile": "https://github.com/willstott101", - "contributions": [ - "code" - ] - }, - { - "login": "demike", - "name": "demike", - "avatar_url": "https://avatars.githubusercontent.com/u/1626922?v=4", - "profile": "https://github.com/demike", - "contributions": [ - "code" - ] - }, - { - "login": "saitonakamura", - "name": "Michael サイトー 中村 Bashurov", - "avatar_url": "https://avatars.githubusercontent.com/u/1552189?v=4", - "profile": "https://github.com/saitonakamura", - "contributions": [ - "code" - ] - }, - { - "login": "jackbonaguro", - "name": "Jack Bonaguro", - "avatar_url": "https://avatars.githubusercontent.com/u/15988128?v=4", - "profile": "https://github.com/jackbonaguro", - "contributions": [ - "code" - ] - }, - { - "login": "rafaelsc", - "name": "Rafael Sliveira Cordeiro", - "avatar_url": "https://avatars.githubusercontent.com/u/502282?v=4", - "profile": "https://github.com/rafaelsc", - "contributions": [ - "code", - "doc" - ] - }, - { - "login": "HEOJUNFO", - "name": "HEOJUNFO", - "avatar_url": "https://avatars.githubusercontent.com/u/100739943?v=4", - "profile": "https://github.com/HEOJUNFO", - "contributions": [ - "code" - ] - }, - { - "login": "Oletus", - "name": "Olli Etuaho", - "avatar_url": "https://avatars.githubusercontent.com/u/453050?v=4", - "profile": "http://www.oletus.fi/", - "contributions": [ - "code" - ] - }, - { - "login": "k2d222", - "name": "Mathis Brossier", - "avatar_url": "https://avatars.githubusercontent.com/u/16296136?v=4", - "profile": "https://github.com/k2d222", - "contributions": [ - "code" - ] - }, - { - "login": "oetherington", - "name": "Ollie Etherington", - "avatar_url": "https://avatars.githubusercontent.com/u/5075628?v=4", - "profile": "https://github.com/oetherington", - "contributions": [ - "code", - "bug" - ] - }, - { - "login": "Mik-pe", - "name": "Mikael Pettersson", - "avatar_url": "https://avatars.githubusercontent.com/u/5653426?v=4", - "profile": "https://github.com/Mik-pe", - "contributions": [ - "code" - ] - }, - { - "login": "magnostherobot", - "name": "Tom Harley", - "avatar_url": "https://avatars.githubusercontent.com/u/24718981?v=4", - "profile": "https://github.com/magnostherobot", - "contributions": [ - "code" - ] - }, - { - "login": "OndrejSpanel", - "name": "Ondřej Španěl", - "avatar_url": "https://avatars.githubusercontent.com/u/6927223?v=4", - "profile": "https://github.com/OndrejSpanel", - "contributions": [ - "bug", - "code", - "doc", - "maintenance" - ] - } - ], - "skipCi": true, - "contributorsPerLine": 7 -} +undefined diff --git a/README.md b/README.md index e93fcb549..a4277c6de 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d Michał Mrozek
Michał Mrozek

💻 - puxiao
puxiao

💻 + puxiao
puxiao

💻 ycw
ycw

💻 Jazcash
Jazcash

💻 Bjorn Stromberg
Bjorn Stromberg

💻 @@ -140,8 +140,9 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d Mikael Pettersson
Mikael Pettersson

💻 - Tom Harley
Tom Harley

💻 + Tom Harley
Tom Harley

💻 Ondřej Španěl
Ondřej Španěl

🐛 💻 📖 🚧 + Yönet
Yönet

💻 @@ -155,4 +156,4 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d ### Why are the declaration files in a `types/three/` directory and why is there a `notNeededPackages.json`? -This makes it easier to re-use the testing process used by DefinitelyTyped since they have a check to make sure the types are within a `types` directory as well a check for `notNeededPackages.json`. It also makes it possible to use `typeRoots` in the `tsconfig.json` so that the `three` types can be resolved correctly in the tests. +This makes it easier to re-use the testing process used by DefinitelyTyped since they have a check to make sure the types are within a `types` directory as well a check for `notNeededPackages.json`. It also makes it possible to use `typeRoots` in the `tsconfig.json` so that the `three` types can be resolved correctly in the tests. \ No newline at end of file diff --git a/types/three/examples/jsm/webxr/XRButton.d.ts b/types/three/examples/jsm/webxr/XRButton.d.ts index 66e7c2657..8d93b5c35 100644 --- a/types/three/examples/jsm/webxr/XRButton.d.ts +++ b/types/three/examples/jsm/webxr/XRButton.d.ts @@ -1,5 +1,6 @@ import { WebGLRenderer } from '../../../src/Three'; +// tslint:disable-next-line:no-unnecessary-class export class XRButton { static createButton(renderer: WebGLRenderer): HTMLElement; } From ef7c7e8a0a9a983aec49f3ef8edaaff6e2791118 Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Sun, 2 Jul 2023 15:32:25 -0400 Subject: [PATCH 4/4] Clean up added contributor --- .all-contributorsrc | 771 +++++++++++++++++++++++++++++++++++++++++++- README.md | 6 +- 2 files changed, 773 insertions(+), 4 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 417b7b537..2acbc2ea8 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1 +1,770 @@ -undefined +{ + "projectName": "three-ts-types", + "projectOwner": "three-types", + "repoType": "github", + "repoHost": "https://github.com", + "files": [ + "README.md" + ], + "imageSize": 100, + "commit": false, + "commitConvention": "none", + "contributors": [ + { + "login": "joshuaellis", + "name": "Josh", + "avatar_url": "https://avatars.githubusercontent.com/u/37798644?v=4", + "profile": "https://github.com/joshuaellis", + "contributions": [ + "question", + "bug", + "code", + "doc", + "ideas", + "maintenance", + "review", + "test" + ] + }, + { + "login": "Methuselah96", + "name": "Nathan Bierema", + "avatar_url": "https://avatars.githubusercontent.com/u/693755?v=4", + "profile": "https://github.com/Methuselah96", + "contributions": [ + "question", + "bug", + "code", + "doc", + "ideas", + "infra", + "maintenance", + "review", + "test" + ] + }, + { + "login": "Mugen87", + "name": "Michael Herzog", + "avatar_url": "https://avatars.githubusercontent.com/u/12612165?v=4", + "profile": "https://human-interactive.org", + "contributions": [ + "code" + ] + }, + { + "login": "CodyJasonBennett", + "name": "Cody Bennett", + "avatar_url": "https://avatars.githubusercontent.com/u/23324155?v=4", + "profile": "https://github.com/CodyJasonBennett", + "contributions": [ + "code" + ] + }, + { + "login": "0b5vr", + "name": "0b5vr", + "avatar_url": "https://avatars.githubusercontent.com/u/7824814?v=4", + "profile": "http://0b5vr.github.io/", + "contributions": [ + "code", + "test", + "maintenance", + "review", + "bug" + ] + }, + { + "login": "marquizzo", + "name": "Marquizzo", + "avatar_url": "https://avatars.githubusercontent.com/u/7864858?v=4", + "profile": "https://stackoverflow.com/users/2608515/marquizzo", + "contributions": [ + "code" + ] + }, + { + "login": "khum08", + "name": "Yuanzk", + "avatar_url": "https://avatars.githubusercontent.com/u/32336026?v=4", + "profile": "https://github.com/khum08", + "contributions": [ + "code" + ] + }, + { + "login": "elisee", + "name": "Elisée Maurer", + "avatar_url": "https://avatars.githubusercontent.com/u/446986?v=4", + "profile": "http://sparklinlabs.com/", + "contributions": [ + "code" + ] + }, + { + "login": "soadzoor", + "name": "soadzoor", + "avatar_url": "https://avatars.githubusercontent.com/u/10392261?v=4", + "profile": "https://github.com/soadzoor", + "contributions": [ + "code" + ] + }, + { + "login": "rinsuki", + "name": "rinsuki", + "avatar_url": "https://avatars.githubusercontent.com/u/6533808?v=4", + "profile": "https://github.com/rinsuki", + "contributions": [ + "code" + ] + }, + { + "login": "efokschaner", + "name": "efokschaner", + "avatar_url": "https://avatars.githubusercontent.com/u/1409112?v=4", + "profile": "https://github.com/efokschaner", + "contributions": [ + "code" + ] + }, + { + "login": "Jhuni0123", + "name": "Jonghun Park", + "avatar_url": "https://avatars.githubusercontent.com/u/16764073?v=4", + "profile": "https://github.com/Jhuni0123", + "contributions": [ + "code" + ] + }, + { + "login": "sjpt", + "name": "sjpt", + "avatar_url": "https://avatars.githubusercontent.com/u/4954988?v=4", + "profile": "https://github.com/sjpt", + "contributions": [ + "code" + ] + }, + { + "login": "Michsior14", + "name": "Michał Mrozek", + "avatar_url": "https://avatars.githubusercontent.com/u/1410035?v=4", + "profile": "https://github.com/Michsior14", + "contributions": [ + "code" + ] + }, + { + "login": "puxiao", + "name": "puxiao", + "avatar_url": "https://avatars.githubusercontent.com/u/3401635?v=4", + "profile": "https://puxiao.com", + "contributions": [ + "code" + ] + }, + { + "login": "ycw", + "name": "ycw", + "avatar_url": "https://avatars.githubusercontent.com/u/1063018?v=4", + "profile": "https://github.com/ycw", + "contributions": [ + "code" + ] + }, + { + "login": "Jazcash", + "name": "Jazcash", + "avatar_url": "https://avatars.githubusercontent.com/u/1434248?v=4", + "profile": "https://github.com/Jazcash", + "contributions": [ + "code" + ] + }, + { + "login": "bjornstar", + "name": "Bjorn Stromberg", + "avatar_url": "https://avatars.githubusercontent.com/u/20630?v=4", + "profile": "https://bjornstar.com/", + "contributions": [ + "code" + ] + }, + { + "login": "happy-turtle", + "name": "HappyTurtle", + "avatar_url": "https://avatars.githubusercontent.com/u/18415215?v=4", + "profile": "https://github.com/happy-turtle", + "contributions": [ + "code" + ] + }, + { + "login": "shuta13", + "name": "Shuta Hirai", + "avatar_url": "https://avatars.githubusercontent.com/u/38882716?v=4", + "profile": "https://studio.did0es.me/", + "contributions": [ + "code" + ] + }, + { + "login": "servinlp", + "name": "Servin Nissen", + "avatar_url": "https://avatars.githubusercontent.com/u/7222029?v=4", + "profile": "https://github.com/servinlp", + "contributions": [ + "code" + ] + }, + { + "login": "benpigchu", + "name": "Ben \"Pig\" Chu", + "avatar_url": "https://avatars.githubusercontent.com/u/9023067?v=4", + "profile": "https://benpigchu.com/", + "contributions": [ + "code" + ] + }, + { + "login": "woo-cie", + "name": "Makoto Yamada", + "avatar_url": "https://avatars.githubusercontent.com/u/24642989?v=4", + "profile": "https://github.com/woo-cie", + "contributions": [ + "code" + ] + }, + { + "login": "schwyzl", + "name": "schwyzl", + "avatar_url": "https://avatars.githubusercontent.com/u/1556979?v=4", + "profile": "https://github.com/schwyzl", + "contributions": [ + "code" + ] + }, + { + "login": "Degubi", + "name": "Degubi", + "avatar_url": "https://avatars.githubusercontent.com/u/13366932?v=4", + "profile": "https://github.com/Degubi", + "contributions": [ + "code" + ] + }, + { + "login": "WCWedin", + "name": "Ibby Wedin", + "avatar_url": "https://avatars.githubusercontent.com/u/110730?v=4", + "profile": "https://github.com/WCWedin", + "contributions": [ + "code" + ] + }, + { + "login": "dbuck", + "name": "dbuck", + "avatar_url": "https://avatars.githubusercontent.com/u/983807?v=4", + "profile": "https://github.com/dbuck", + "contributions": [ + "code" + ] + }, + { + "login": "robertlong", + "name": "Robert Long", + "avatar_url": "https://avatars.githubusercontent.com/u/1753624?v=4", + "profile": "https://github.com/robertlong", + "contributions": [ + "code" + ] + }, + { + "login": "XertroV", + "name": "Max Kaye", + "avatar_url": "https://avatars.githubusercontent.com/u/1046448?v=4", + "profile": "https://xk.io/", + "contributions": [ + "doc" + ] + }, + { + "login": "LauferAlex", + "name": "Alejandro Laufer", + "avatar_url": "https://avatars.githubusercontent.com/u/86115165?v=4", + "profile": "https://github.com/LauferAlex", + "contributions": [ + "bug", + "code" + ] + }, + { + "login": "gsimone", + "name": "Gianmarco", + "avatar_url": "https://avatars.githubusercontent.com/u/1862172?v=4", + "profile": "https://twitter.com/ggsimm", + "contributions": [ + "code" + ] + }, + { + "login": "DavidPeicho", + "name": "David Peicho", + "avatar_url": "https://avatars.githubusercontent.com/u/8783766?v=4", + "profile": "https://davidpeicho.github.io/", + "contributions": [ + "code" + ] + }, + { + "login": "trusktr", + "name": "Joe Pea", + "avatar_url": "https://avatars.githubusercontent.com/u/297678?v=4", + "profile": "https://github.com/trusktr", + "contributions": [ + "code" + ] + }, + { + "login": "subhankar-trisetra", + "name": "Subhankar Pal", + "avatar_url": "https://avatars.githubusercontent.com/u/98544661?v=4", + "profile": "https://subho57.github.io", + "contributions": [ + "code" + ] + }, + { + "login": "capnmidnight", + "name": "Sean T. McBeth", + "avatar_url": "https://avatars.githubusercontent.com/u/298046?v=4", + "profile": "http://www.seanmcbeth.com/", + "contributions": [ + "code" + ] + }, + { + "login": "atulrnt", + "name": "Arthur LAURENT", + "avatar_url": "https://avatars.githubusercontent.com/u/894203?v=4", + "profile": "https://github.com/atulrnt", + "contributions": [ + "code" + ] + }, + { + "login": "serenayl", + "name": "Serena Li", + "avatar_url": "https://avatars.githubusercontent.com/u/12814119?v=4", + "profile": "https://github.com/serenayl", + "contributions": [ + "code" + ] + }, + { + "login": "cosformula", + "name": "cosformula", + "avatar_url": "https://avatars.githubusercontent.com/u/18232501?v=4", + "profile": "https://github.com/cosformula", + "contributions": [ + "code" + ] + }, + { + "login": "miko3k", + "name": "Peter Hanula", + "avatar_url": "https://avatars.githubusercontent.com/u/8658482?v=4", + "profile": "https://github.com/miko3k", + "contributions": [ + "code" + ] + }, + { + "login": "MysteryBlokHed", + "name": "Adam Thompson-Sharpe", + "avatar_url": "https://avatars.githubusercontent.com/u/13910387?v=4", + "profile": "https://github.com/MysteryBlokHed", + "contributions": [ + "code" + ] + }, + { + "login": "noname0310", + "name": "noname", + "avatar_url": "https://avatars.githubusercontent.com/u/48761044?v=4", + "profile": "https://www.youtube.com/c/noname0310", + "contributions": [ + "code" + ] + }, + { + "login": "grschafer", + "name": "Greg Schafer", + "avatar_url": "https://avatars.githubusercontent.com/u/694225?v=4", + "profile": "https://github.com/grschafer", + "contributions": [ + "code" + ] + }, + { + "login": "SuperSodaSea", + "name": "SuperSodaSea", + "avatar_url": "https://avatars.githubusercontent.com/u/8724868?v=4", + "profile": "https://github.com/SuperSodaSea", + "contributions": [ + "code" + ] + }, + { + "login": "mattrossman", + "name": "Matt Rossman", + "avatar_url": "https://avatars.githubusercontent.com/u/22670878?v=4", + "profile": "https://github.com/mattrossman", + "contributions": [ + "code" + ] + }, + { + "login": "alexpineda", + "name": "Alex Pineda", + "avatar_url": "https://avatars.githubusercontent.com/u/586716?v=4", + "profile": "https://github.com/imbateam-gg/titan-reactor", + "contributions": [ + "code" + ] + }, + { + "login": "Draichi", + "name": "Lucas", + "avatar_url": "https://avatars.githubusercontent.com/u/19378148?v=4", + "profile": "https://draichiboard.vercel.app/", + "contributions": [ + "doc" + ] + }, + { + "login": "mz8i", + "name": "Maciej Ziarkowski", + "avatar_url": "https://avatars.githubusercontent.com/u/36160844?v=4", + "profile": "https://github.com/mz8i", + "contributions": [ + "code" + ] + }, + { + "login": "Suprhimp", + "name": "Suprhimp", + "avatar_url": "https://avatars.githubusercontent.com/u/73486185?v=4", + "profile": "https://github.com/Suprhimp", + "contributions": [ + "code" + ] + }, + { + "login": "Trinovantes", + "name": "Stephen Li", + "avatar_url": "https://avatars.githubusercontent.com/u/458691?v=4", + "profile": "https://www.stephenli.ca/", + "contributions": [ + "code" + ] + }, + { + "login": "autonomobil", + "name": "Moritz Cremer", + "avatar_url": "https://avatars.githubusercontent.com/u/31781343?s=96&v=4", + "profile": "https://github.com/autonomobil", + "contributions": [ + "code" + ] + }, + { + "login": "LuchoTurtle", + "name": "LuchoTurtle", + "avatar_url": "https://avatars.githubusercontent.com/u/17494745?v=4", + "profile": "https://github.com/LuchoTurtle", + "contributions": [ + "code" + ] + }, + { + "login": "marwie", + "name": "Marcel Wiessler", + "avatar_url": "https://avatars.githubusercontent.com/u/5083203?v=4", + "profile": "https://www.needle.tools", + "contributions": [ + "code" + ] + }, + { + "login": "JoshStern", + "name": "Josh Stern", + "avatar_url": "https://avatars.githubusercontent.com/u/10948202?v=4", + "profile": "https://github.com/JoshStern", + "contributions": [ + "code" + ] + }, + { + "login": "rotu", + "name": "Dan Rose", + "avatar_url": "https://avatars.githubusercontent.com/u/119948?v=4", + "profile": "https://github.com/rotu", + "contributions": [ + "code" + ] + }, + { + "login": "gegoggigog", + "name": "Dan Dolonius", + "avatar_url": "https://avatars.githubusercontent.com/u/1716001?v=4", + "profile": "https://github.com/gegoggigog", + "contributions": [ + "code" + ] + }, + { + "login": "Hoodgail", + "name": "Benjamin", + "avatar_url": "https://avatars.githubusercontent.com/u/45743294?v=4", + "profile": "https://hoodgail.com/", + "contributions": [ + "code" + ] + }, + { + "login": "agviegas", + "name": "Antonio González Viegas", + "avatar_url": "https://avatars.githubusercontent.com/u/56475338?v=4", + "profile": "https://www.linkedin.com/in/antonio-gonz%C3%A1lez-viegas-8b2326151/", + "contributions": [ + "code" + ] + }, + { + "login": "donmccurdy", + "name": "Don McCurdy", + "avatar_url": "https://avatars.githubusercontent.com/u/1848368?v=4", + "profile": "https://www.donmccurdy.com/", + "contributions": [ + "code" + ] + }, + { + "login": "xawill", + "name": "Xavier Willemin", + "avatar_url": "https://avatars.githubusercontent.com/u/2658206?v=4", + "profile": "https://github.com/xawill", + "contributions": [ + "code" + ] + }, + { + "login": "r00ster91", + "name": "zooster", + "avatar_url": "https://avatars.githubusercontent.com/u/35064754?v=4", + "profile": "https://github.com/r00ster91", + "contributions": [ + "code" + ] + }, + { + "login": "andersonleite", + "name": "Anderson Leite", + "avatar_url": "https://avatars.githubusercontent.com/u/52427?v=4", + "profile": "https://github.com/andersonleite", + "contributions": [ + "code" + ] + }, + { + "login": "frading", + "name": "Guillaume Fradin", + "avatar_url": "https://avatars.githubusercontent.com/u/59701?v=4", + "profile": "https://polygonjs.com/", + "contributions": [ + "code" + ] + }, + { + "login": "Heaust-ops", + "name": "Heaust Azure", + "avatar_url": "https://avatars.githubusercontent.com/u/54670936?v=4", + "profile": "https://github.com/Heaust-ops", + "contributions": [ + "code" + ] + }, + { + "login": "Gallahron", + "name": "Joe Tipping", + "avatar_url": "https://avatars.githubusercontent.com/u/39060404?v=4", + "profile": "http://www.joemo.co.uk/", + "contributions": [ + "code" + ] + }, + { + "login": "lgarron", + "name": "Lucas Garron", + "avatar_url": "https://avatars.githubusercontent.com/u/248078?v=4", + "profile": "https://garron.net/", + "contributions": [ + "code" + ] + }, + { + "login": "maccesch", + "name": "Marc-Stefan Cassola", + "avatar_url": "https://avatars.githubusercontent.com/u/380881?v=4", + "profile": "https://github.com/maccesch", + "contributions": [ + "code" + ] + }, + { + "login": "peterblazejewicz", + "name": "Piotr Błażejewicz (Peter Blazejewicz)", + "avatar_url": "https://avatars.githubusercontent.com/u/14539?v=4", + "profile": "http://www.linkedin.com/in/peterblazejewicz", + "contributions": [ + "code" + ] + }, + { + "login": "Vikontte", + "name": "Victoria Shadrina", + "avatar_url": "https://avatars.githubusercontent.com/u/18411533?v=4", + "profile": "https://github.com/Vikontte", + "contributions": [ + "code" + ] + }, + { + "login": "willstott101", + "name": "Will Stott", + "avatar_url": "https://avatars.githubusercontent.com/u/335152?v=4", + "profile": "https://github.com/willstott101", + "contributions": [ + "code" + ] + }, + { + "login": "demike", + "name": "demike", + "avatar_url": "https://avatars.githubusercontent.com/u/1626922?v=4", + "profile": "https://github.com/demike", + "contributions": [ + "code" + ] + }, + { + "login": "saitonakamura", + "name": "Michael サイトー 中村 Bashurov", + "avatar_url": "https://avatars.githubusercontent.com/u/1552189?v=4", + "profile": "https://github.com/saitonakamura", + "contributions": [ + "code" + ] + }, + { + "login": "jackbonaguro", + "name": "Jack Bonaguro", + "avatar_url": "https://avatars.githubusercontent.com/u/15988128?v=4", + "profile": "https://github.com/jackbonaguro", + "contributions": [ + "code" + ] + }, + { + "login": "rafaelsc", + "name": "Rafael Sliveira Cordeiro", + "avatar_url": "https://avatars.githubusercontent.com/u/502282?v=4", + "profile": "https://github.com/rafaelsc", + "contributions": [ + "code", + "doc" + ] + }, + { + "login": "HEOJUNFO", + "name": "HEOJUNFO", + "avatar_url": "https://avatars.githubusercontent.com/u/100739943?v=4", + "profile": "https://github.com/HEOJUNFO", + "contributions": [ + "code" + ] + }, + { + "login": "Oletus", + "name": "Olli Etuaho", + "avatar_url": "https://avatars.githubusercontent.com/u/453050?v=4", + "profile": "http://www.oletus.fi/", + "contributions": [ + "code" + ] + }, + { + "login": "k2d222", + "name": "Mathis Brossier", + "avatar_url": "https://avatars.githubusercontent.com/u/16296136?v=4", + "profile": "https://github.com/k2d222", + "contributions": [ + "code" + ] + }, + { + "login": "oetherington", + "name": "Ollie Etherington", + "avatar_url": "https://avatars.githubusercontent.com/u/5075628?v=4", + "profile": "https://github.com/oetherington", + "contributions": [ + "code", + "bug" + ] + }, + { + "login": "Mik-pe", + "name": "Mikael Pettersson", + "avatar_url": "https://avatars.githubusercontent.com/u/5653426?v=4", + "profile": "https://github.com/Mik-pe", + "contributions": [ + "code" + ] + }, + { + "login": "magnostherobot", + "name": "Tom Harley", + "avatar_url": "https://avatars.githubusercontent.com/u/24718981?v=4", + "profile": "https://github.com/magnostherobot", + "contributions": [ + "code" + ] + }, + { + "login": "OndrejSpanel", + "name": "Ondřej Španěl", + "avatar_url": "https://avatars.githubusercontent.com/u/6927223?v=4", + "profile": "https://github.com/OndrejSpanel", + "contributions": [ + "bug", + "code", + "doc", + "maintenance" + ] + }, + { + "login": "Yonet", + "name": "Yönet", + "avatar_url": "https://avatars.githubusercontent.com/u/3523671?v=4", + "profile": "https://github.com/Yonet", + "contributions": [ + "code" + ] + } + ], + "skipCi": true, + "contributorsPerLine": 7 +} diff --git a/README.md b/README.md index a4277c6de..a3488da68 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d Michał Mrozek
Michał Mrozek

💻 - puxiao
puxiao

💻 + puxiao
puxiao

💻 ycw
ycw

💻 Jazcash
Jazcash

💻 Bjorn Stromberg
Bjorn Stromberg

💻 @@ -140,7 +140,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d Mikael Pettersson
Mikael Pettersson

💻 - Tom Harley
Tom Harley

💻 + Tom Harley
Tom Harley

💻 Ondřej Španěl
Ondřej Španěl

🐛 💻 📖 🚧 Yönet
Yönet

💻 @@ -156,4 +156,4 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d ### Why are the declaration files in a `types/three/` directory and why is there a `notNeededPackages.json`? -This makes it easier to re-use the testing process used by DefinitelyTyped since they have a check to make sure the types are within a `types` directory as well a check for `notNeededPackages.json`. It also makes it possible to use `typeRoots` in the `tsconfig.json` so that the `three` types can be resolved correctly in the tests. \ No newline at end of file +This makes it easier to re-use the testing process used by DefinitelyTyped since they have a check to make sure the types are within a `types` directory as well a check for `notNeededPackages.json`. It also makes it possible to use `typeRoots` in the `tsconfig.json` so that the `three` types can be resolved correctly in the tests.