Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking for admins should always be reloaded from disk #1849

Open
xmonader opened this issue Dec 16, 2020 · 2 comments
Open

checking for admins should always be reloaded from disk #1849

xmonader opened this issue Dec 16, 2020 · 2 comments
Labels
type_feature
Milestone
later

Comments

@xmonader
Copy link
Collaborator

Right now, a server running and I want to add an admin, I should go to the active running server shell and do it there and can't be done from any other shell. I think it's best if we always reload when checking the admins..
@rkhamis rkhamis added this to the next milestone Dec 16, 2020
@xmonader xmonader modified the milestones: next, later Jan 13, 2021
@xmonader xmonader modified the milestones: next, later Jan 13, 2021
@xmonader
Copy link
Collaborator Author

@ashraffouda please add your suggestions here as well

@ashraffouda
Copy link
Collaborator

@ashraffouda please add your suggestions here as well
I suggest to make this change in redis like when updating that on disk it updates redis and read the admins from redis after that
also if it is possible to have this on the ui so the user can easily add admins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type_feature
Projects
None yet
Milestone
later
Development

No branches or pull requests
4 participants
@xmonader @ashraffouda @rkhamis @sasha-astiadi