Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a common components library to be used in all of our packages #755

Open
abom opened this issue Aug 30, 2020 · 4 comments
Open

create a common components library to be used in all of our packages #755

abom opened this issue Aug 30, 2020 · 4 comments
Assignees
Milestone

Comments

@abom
Copy link
Contributor

abom commented Aug 30, 2020

Description

Now we have multiple packages where we use vue, and we duplicate components (specially common ones).

Implementation

Create a library for common components that can be used in any of our projects, which would be better in many ways (a single code-base to maintain, a consistent view across multiple products...etc)

More

AFAIK, the following ones contain very similar (nearly identical) components:

1- admin
2- marketplace
3- chatflows
4- marketplacevdc

required for threefoldtech/home#1046

@rkhamis rkhamis changed the title create a common components library to be used in all of our packages create a common components library to be used in all of our packages (weight=5) Sep 2, 2020
@xmonader xmonader added this to the next milestone Oct 18, 2020
@xmonader xmonader modified the milestones: next, later Jan 13, 2021
@xmonader xmonader modified the milestones: later, next Jan 13, 2021
@xmonader
Copy link
Collaborator

depending on the timeline for 11.2 we should pick this up or not, to reduce the technical debt

@abom
Copy link
Contributor Author

abom commented Jan 18, 2021

As we currently work with Vue the ESM way (no dist, no builds...etc), so we don't need to create an npm package or bundle the lib using e.g. webpack or so, I suggest we just do a package which is installed by default (like weblibs) that contains common components and helpers, hence vue-http-loader will be happy to load them easily.

I added a small POC at #2278.

Also, I hope we can list the following here before we start:

  • Duplicate components across different packages
  • Similar components that needs changes in both the base component and where it's used

@samaradel
Copy link
Contributor

samaradel commented Feb 1, 2021

Updated.

Duplicated components:

  • base
  • solutions

@xmonader xmonader modified the milestones: next, later Mar 23, 2021
@rkhamis rkhamis changed the title create a common components library to be used in all of our packages (weight=5) create a common components library to be used in all of our packages May 17, 2021
@xmonader
Copy link
Collaborator

the poc exists here #2278 let's continue that in 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants