Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[research] file upload support for rmb-peer #132

Closed
Tracked by #1437
muhamadazmy opened this issue May 12, 2023 · 1 comment
Closed
Tracked by #1437

[research] file upload support for rmb-peer #132

muhamadazmy opened this issue May 12, 2023 · 1 comment
Assignees
Milestone

Comments

@muhamadazmy
Copy link
Member

Related to #103

Introduction

RMB (relay) and messages can totally support file upload without changes. While it's a message protocol a message payload can be anything (for example chunk of a file) hence 2 peers implementing the protocols can perfectly agree to upload a file over multiple chunks and communicate ahead of the upload.

Things get a little bit more complicated when the rmb-peer implementation comes in between. the rmb-peer job is to implement a "gateway" that can run locally and then send and receive messages on behalf on multiple apps that can be running next to each other on the same local machine. It receive a request from a local machine, send it to remote peer, wait for answer and then send it back to the original caller.

For file upload the requirements state that, the local app send a request to the local peer, that peer then take care of communicating the file upload with the remote rmb-peer, then implement the upload (over chunks) or communicate errors back to the caller.

This sounds easier than in reality duo to async nature of the protocol. The rmb-peer then need to be changed a little bit to add more layers where we can inject application behavior (like extensions) inside peer itself.

Anyway this is about the research needed to be done to implement the right architecture to support this

@muhamadazmy muhamadazmy self-assigned this May 12, 2023
@muhamadazmy muhamadazmy moved this to Accepted in 3.11.x May 12, 2023
@muhamadazmy
Copy link
Member Author

Implementation in progress. research phase is complete

@github-project-automation github-project-automation bot moved this from Accepted to Done in 3.11.x Jun 7, 2023
@xmonader xmonader added this to the 1.0.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants