Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to rate limiting #191

Open
muhamadazmy opened this issue Feb 20, 2024 · 0 comments
Open

improvements to rate limiting #191

muhamadazmy opened this issue Feb 20, 2024 · 0 comments
Labels
priority_minor type_feature New feature or request
Milestone

Comments

@muhamadazmy
Copy link
Member

We already have a rate limit feature implemented on the relay side to prevent peers from flooding the relay with messages. This works fine. But what we haven't considered is since anyone can host his own relay he can configure his limits (or no limits) which means his messages will still be delivered over federation.

I was wondering if it's a good idea to also set the same limiting mechanism on the "federation" API so a source twin "total number of messages" is aggregated on BOTH ends (over the websocket end where he is connected directly) and the (http end if his message is federated from another relay)

@ramezsaeed ramezsaeed added the type_feature New feature or request label May 8, 2024
@ramezsaeed ramezsaeed added this to 3.15.x May 8, 2024
@ramezsaeed ramezsaeed added this to the 1.3.0 milestone May 8, 2024
@ashraffouda ashraffouda modified the milestones: 1.3.0, 1.5.0 May 8, 2024
@rawdaGastan rawdaGastan removed this from 3.15.x Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor type_feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants