From ef21c0c59edae1b241f8daf59ce3e1c877ddae05 Mon Sep 17 00:00:00 2001 From: zaelgohary Date: Thu, 22 Feb 2024 12:38:04 +0200 Subject: [PATCH 1/2] Slice Iperf array to contain only 4 elemnts max --- .../components/node_details_cards/iperf_details_card.vue | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/playground/src/components/node_details_cards/iperf_details_card.vue b/packages/playground/src/components/node_details_cards/iperf_details_card.vue index 114dd2a8f2..88d20d5980 100644 --- a/packages/playground/src/components/node_details_cards/iperf_details_card.vue +++ b/packages/playground/src/components/node_details_cards/iperf_details_card.vue @@ -61,7 +61,7 @@ export default { const getNodeIPerfCard = async (): Promise => { const res = await gridStore.grid.zos.getNodeIPerfTest({ nodeId: props.node.nodeId }); // filter the returned result to show node other than the one being tested against - const array = res.result + let array = res.result .filter( (node: any) => node.download_speed && node.upload_speed && !node.error && node.node_id !== props.node.nodeId, ) @@ -71,6 +71,10 @@ export default { downloadSpeed: format(node.download_speed), uploadSpeed: format(node.upload_speed), })); + + if (array.length > 4) { + array = array.slice(4); + } IperfDetails.value = array; return IperfDetails.value; }; From 0bb3d3a00a3d5c00a8d91748a911f7d0dd67ce16 Mon Sep 17 00:00:00 2001 From: zaelgohary Date: Thu, 22 Feb 2024 13:23:55 +0200 Subject: [PATCH 2/2] Chain slicing instead of doing it in a check --- .../components/node_details_cards/iperf_details_card.vue | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/playground/src/components/node_details_cards/iperf_details_card.vue b/packages/playground/src/components/node_details_cards/iperf_details_card.vue index 88d20d5980..b51ad85b51 100644 --- a/packages/playground/src/components/node_details_cards/iperf_details_card.vue +++ b/packages/playground/src/components/node_details_cards/iperf_details_card.vue @@ -61,10 +61,11 @@ export default { const getNodeIPerfCard = async (): Promise => { const res = await gridStore.grid.zos.getNodeIPerfTest({ nodeId: props.node.nodeId }); // filter the returned result to show node other than the one being tested against - let array = res.result + const array = res.result .filter( (node: any) => node.download_speed && node.upload_speed && !node.error && node.node_id !== props.node.nodeId, ) + .slice(0, 4) .map(node => ({ name: node.test_type.toLocaleUpperCase(), type: isIPv4(node.node_ip) ? "IPv4" : "IPv6", @@ -72,9 +73,6 @@ export default { uploadSpeed: format(node.upload_speed), })); - if (array.length > 4) { - array = array.slice(4); - } IperfDetails.value = array; return IperfDetails.value; };