Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Fix grid client tests #3711

Open
2 of 6 tasks
ramezsaeed opened this issue Dec 5, 2024 · 1 comment
Open
2 of 6 tasks

🐞 [Bug]: Fix grid client tests #3711

ramezsaeed opened this issue Dec 5, 2024 · 1 comment
Labels
type_bug Something isn't working
Milestone

Comments

@ramezsaeed
Copy link
Contributor

ramezsaeed commented Dec 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

grid_client

What happened?

--
We have 11 failed tests should be fixed or skipped here

Test Suites: 6 failed, 2 skipped, 23 passed, 29 of 31 total
Tests: 11 failed, 5 skipped, 97 passed, 113 total

https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/12171285155/job/33947900286

Steps To Reproduce

  • Run tests locally to check all the failures
  • fix failed tests
  • check the skipped tests if they are still valid
  • do the needed skip for tests still failing with link to the issues reported.

Related issues:

which network/s did you face the problem on?

Dev

version

2.6.0

Relevant screenshots/screen records

Screenshot from 2024-12-05 16-25-28

Relevant log output

https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/12171285155/job/33947900286
@ramezsaeed ramezsaeed added the type_bug Something isn't working label Dec 5, 2024
@ramezsaeed ramezsaeed changed the title 🐞 [Bug]: Fix grid client tests workflow 🐞 [Bug]: Fix grid client tests Dec 5, 2024
@ramezsaeed ramezsaeed added this to the 2.7.0 milestone Dec 24, 2024
@ramezsaeed
Copy link
Contributor Author

latest run
Tests: 4 failed, 4 skipped, 107 passed, 115 total
https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/12531218960/job/34948599948

Screenshot from 2024-12-29 16-34-04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant