Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow farmer to choose whether to upgrade or not #900

Closed
LeeSmet opened this issue Aug 20, 2020 · 5 comments
Closed

Allow farmer to choose whether to upgrade or not #900

LeeSmet opened this issue Aug 20, 2020 · 5 comments
Assignees
Labels
priority_minor type_feature New feature or request

Comments

@LeeSmet
Copy link
Contributor

LeeSmet commented Aug 20, 2020

Right now all nodes automatically update, we need to add an option for a farmer to choose if he wants to upgrade

@LeeSmet LeeSmet added type_feature New feature or request priority_major labels Aug 20, 2020
@LeeSmet LeeSmet added this to the now milestone Aug 20, 2020
@DylanVerstraete DylanVerstraete self-assigned this Aug 20, 2020
@DylanVerstraete DylanVerstraete linked a pull request Aug 20, 2020 that will close this issue
@DylanVerstraete
Copy link
Contributor

For now our idea was to add a field on the farmer struct that controls automatic upgrades for his nodes in his farm.
We might want to think about allowing manual upgrades and how we are going to handle that.

Also there are some more things to think about when a farmer decides not to upgrade his nodes. He will need to run his own explorer, migrate data, etc ..

@zaibon
Copy link
Contributor

zaibon commented Aug 21, 2020

I think we need to have a more broad reflection about this. From the top of my head here are some question I think we need to answer:

  • Does the choice apply on farm level or on node level ? Can a farmer choose to upgrade only some of it's node?
  • What happens if a farmer decide no to upgrade and there are a breaking change with the explorer API ? Do we prevent the node from processing reservation ?
  • If the farmer choice to not upgrade automatically: what choice does it have ? Upgrade to a specific version ? Upgrade to latest ? How to ensure all upgrade are applied and he doesn't skip one ?
  • Should we start creating LTS releases ?
  • Should we start maintaining multiple version ?

@zaibon
Copy link
Contributor

zaibon commented Aug 25, 2020

After gather more information about what is actually expected around this, here is what is planned.

1st phase: We ask each farmer to sign an auto upgrade agreement. Once he has sign it, all it's farms have auto upgrade enabled. Nothing more then that.

2nd phase: We can reflect around how granular we want the upgrade to be and let the farmer be fully in control. For this we need to answer all the question from my previous comment:

Does the choice apply on farm level or on node level ? Can a farmer choose to upgrade only some of it's node?
What happens if a farmer decide no to upgrade and there are a breaking change with the explorer API ? Do we prevent the node from processing reservation ?
If the farmer choice to not upgrade automatically: what choice does it have ? Upgrade to a specific version ? Upgrade to latest ? How to ensure all upgrade are applied and he doesn't skip one ?
Should we start creating LTS releases ?
Should we start maintaining multiple version ?

@zaibon
Copy link
Contributor

zaibon commented Aug 25, 2020

@muhamadazmy muhamadazmy modified the milestones: now, next Jan 14, 2021
@DylanVerstraete
Copy link
Contributor

We should close all current work done for it and come up with a new strategy in grid 3.0. I think the digital twin from the farmer can take care of this.

@xmonader xmonader removed this from the next milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor type_feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants