Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect FLIP #7

Open
zoharl3 opened this issue Jul 7, 2022 · 0 comments
Open

Incorrect FLIP #7

zoharl3 opened this issue Jul 7, 2022 · 0 comments

Comments

@zoharl3
Copy link

zoharl3 commented Jul 7, 2022

A pseudo code of FLIP is given in section 4.2 in

Zhu05, Animating Sand as a Fluid

Consider manta's flip01_simple.py.

flipVelocityUpdate() calculates FLIP correctly and associates the weighted FLIP/PIC velocity with each particle.

However, in pp.advectInGrid(), the Euler step is done with the interpolated new velocity in the grid without the FLIP step while the algorithm suggests to use the weighted velocity in the particle.

The calculated FLIP velocity is used only in mapPartsToMAC().

I assume it was easier to perform the Runge-Kutta this way instead of delta velocity.

Admittedly, this bug works better than the original algorithm and may be considered a feature :) However, consider at least adding a comment about it to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant