Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not look at src/ folder #44

Closed
rbuckland opened this issue Nov 13, 2023 · 4 comments
Closed

does not look at src/ folder #44

rbuckland opened this issue Nov 13, 2023 · 4 comments

Comments

@rbuckland
Copy link

We have the alternative standard layout of a src folder

pyproject.toml
src/module_thing/__init__.py

this plugin is trying to read

pyproject.toml
module_thing/__init__.py
@Messinger
Copy link

yes. Defining a prefix where to search for the package base folder would be really useful. Using "src/<packagename>" is some kind of standard because in larger projects you need some data beside the package itself.

Eg, having a kind of "prefix" as configure option would be very helpul, eg.,

[tool.poetry-version-plugin]
source = "init"
search="backend"

or

[tool.poetry-version-plugin]
source = "init"
search="src"

would improve the usability of this nice plugin a lot.

@brookpatten
Copy link

brookpatten commented Dec 6, 2023

I think for best compatibility, this could be inferred from the "packages" config from field, eg

packages = [{include = "mypackage", from = "src"}]

Instead of adding special configuration for the plugin

I think this is effectively a duplicate of #19 and #43 and is fixed by 51416e4 , but not merged?

@kzych-inpost
Copy link

I think for best compatibility, this could be inferred from the "packages" config from field, eg

packages = [{include = "mypackage", from = "src"}]

It still does not work this way :/

@tiangolo
Copy link
Owner

tiangolo commented Sep 8, 2024

Thanks for the patience with my reply! 😅

I just marked this project as deprecated, I'm currently not using it and I think these ideas can be achieved in better ways: https://github.com/tiangolo/poetry-version-plugin#-warning-deprecated-

Given that I'll close this one, but thanks for the interest! ☕

@tiangolo tiangolo closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants