From 3c4448653f8ed0a5570a53c66a7675b7194b6088 Mon Sep 17 00:00:00 2001 From: Andre Castro Date: Tue, 18 Jun 2024 09:15:21 +0200 Subject: [PATCH] CSV fix: 2.31 Agrar-, Forstwissenschaften und Tiermedizin --- csv/2024-2028/Fachsystematik_2024-2028.csv | 24 ++++++----------- csv_parsing_errors.md | 31 +++++++++++++++++++++- 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/csv/2024-2028/Fachsystematik_2024-2028.csv b/csv/2024-2028/Fachsystematik_2024-2028.csv index 5d81e8a..8f94688 100644 --- a/csv/2024-2028/Fachsystematik_2024-2028.csv +++ b/csv/2024-2028/Fachsystematik_2024-2028.csv @@ -872,64 +872,56 @@ Lebenswissenschaften" Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-01,Bodenwissenschaften,"2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-02,Plant Breeding and Plant Pathology,"2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-02,"Pflanzenzüchtung, Pflanzenpathologie","2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-03,"Plant Cultivation, Plant Nutrition, Agricultural Technology","2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-03,"Pflanzenbau, Pflanzenernährung, Agrartechnik","2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-04,Ecology of Land Use,"2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-04,Ökologie der Landnutzung,"2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-05,"Agricultural Economics, Agricultural Policy, Agricultural Sociology","2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-05,"Agrarökonomie, Agrarpolitik, Agrarsoziologie","2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-06,Forestry,"2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-06,Forstwissenschaften,"2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-07,"Animal Breeding, Animal Nutrition, Animal Husbandry","2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-07,"Tierzucht, Tierernährung, Tierhaltung","2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 2.31-08,Veterinary Medical Science,"2.31 Agriculture, Forestry and Veterinary Medicine","23 Agriculture, Forestry and Veterinary Medicine","2 Life Sciences",2.31-08,Tiermedizin,"2.31 -Agrar-, Forstwissenschaften -und Tiermedizin","23 +Agrar-, Forstwissenschaften und Tiermedizin","23 Agrar-, Forstwissen- schaften und Tiermedizin","2 Lebenswissenschaften" 3.11-01,Inorganic Molecular Chemistry - Synthesis and Characterisation,"3.11 diff --git a/csv_parsing_errors.md b/csv_parsing_errors.md index bbddd7b..98f84ed 100644 --- a/csv_parsing_errors.md +++ b/csv_parsing_errors.md @@ -30,4 +30,33 @@ Unlike other "Subject Area" values that seperate `NN Subject` with a line break, **Fix:** Search & Replace in CSV `11 Humanities` for `"11\nHumanities"` -**Commit:** \ No newline at end of file +**Commit:** b857e8c8dfb980fb2407a8b3d92bd6cb64d67fc9 + +## Error om + +```python +SECTION: 2 Review Board +INDEX: 2 COL:Review Board CELL: 2.31 +Agriculture, Forestry and Veterinary Medicine +id_n_label: 2.31 +Agriculture, Forestry and Veterinary Medicine +id_n_label: 2.31 +Agrar-, Forstwissenschaften +und Tiermedizin +Traceback (most recent call last): + File "/home/acastro/Documents/external_projects/DFG-Fachsystematik-Ontology/scripts/create_ontology.py", line 99, in + cell_id_de, cell_label_de = split_id_label(id_n_label=cell_de) + File "/home/acastro/Documents/external_projects/DFG-Fachsystematik-Ontology/scripts/create_ontology.py", line 35, in split_id_label + id, label = id_n_label.split('\n') +ValueError: too many values to unpack (expected 2) +``` + +**Issue:** 2.31 has 2 line breaks, when it should only have 1, between number and term +``` +2.31 +Agrar-, Forstwissenschaften +und Tiermedizin +``` + +**Fix:** +Search & Replace in CSV `Agrar-, Forstwissenschaften\nund Tiermedizin` for `"Agrar-, Forstwissenschaften und Tiermedizin"`