New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for UNSIGNED-PAYLOAD #20

Open

dbolotin opened this issue Nov 10, 2017 · 1 comment

dbolotin commented Nov 10, 2017 •

edited

Loading

UNSIGNED-PAYLOAD as described here is not supported now.

If you want I can make a PR. But adding this functionality will require some API modification. I suggest the following changes:

create sealed trait Payload with the following subtypes:
- StringPayload
- BytesPayload
- PreCalculatedSHA256
- UnsignedPayload (for UNSIGNED-PAYLOAD here)
- StreamingPayload (for STREAMING-AWS4-HMAC-SHA256-PAYLOAD, as described here)
change type of payload parameter from Option[Array[Byte]] to Payload

Please let me know your thought on this.

The text was updated successfully, but these errors were encountered:

Author

dbolotin commented Nov 10, 2017

Please see my PR with less invasive modifications to support this type of requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment