fix dexcom task retry logic #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjotala
reviewed
Oct 25, 2023
| } | ||
| count, ok := t.Data[dexcomTaskRetryField].(int) | ||
| if ok { | ||
| return count >= 3 | ||
| } | ||
| return true |
There was a problem hiding this comment.
Should we reset it to 0 in case it fails to parse? That way it would automatically recover from (what appears to be) bad data in the DB.
There was a problem hiding this comment.
A few thoughts:
- Consider logging this failure as an error so we can detect if/when it happens.
- Is there a non-linear fallback, just in case there is a bug in the code and this happens repeatedly?
- You might consider shortening this code to eliminate the extra parse by returning immediately after setting the field to 0.
|
super seeded by later work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.