Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is spatialsample ready for v1.0.0? #147

Open
mikemahoney218 opened this issue Jul 24, 2023 · 0 comments
Open

Is spatialsample ready for v1.0.0? #147

mikemahoney218 opened this issue Jul 24, 2023 · 0 comments

Comments

@mikemahoney218
Copy link
Member

I think spatialsample is ready for version 1.0.0. We're building on top of rsample >= 1.0.0, which has had a pretty stable interface for multiple years, and I'd be surprised myself if much of the interface or the returned objects changed in the future.

The main reasons spatialsample wouldn't be 1.0.0 ready that I can think of would be:

  • Stratification isn't supported, and isn't currently on the short-term roadmap (but might be in the future). This might cause a big change to the package.
  • spatial_nndm_cv() is still somewhat experimental and might change in the future, as the team that introduced NNDM is talking about proposing a V-fold variant.

Still, I think we're in a place where the next release could be a 1.0.0 release. I'm opening this issue to see what others think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant