Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunable updates for tailor #272

Merged
merged 4 commits into from
Dec 2, 2024
Merged

tunable updates for tailor #272

merged 4 commits into from
Dec 2, 2024

Conversation

topepo
Copy link
Member

@topepo topepo commented Dec 2, 2024

We were not adding postprocessing parameters to tunable() results.

Also added tests for tunable() including one from extratests, related to #194

@topepo topepo marked this pull request as ready for review December 2, 2024 14:19
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar!

You note this is related to #194. It seems like it should close that issue? And possibly open a new issue in extratests to remind us to remove redundant tests from this file.

tests/testthat/test-generics.R Show resolved Hide resolved
@topepo
Copy link
Member Author

topepo commented Dec 2, 2024

I would do PRs in the other packages (like recipes) first, then remove the file.

I didn't bring the tune_args() tests over. I can do that this week.

@topepo topepo merged commit 784d0fd into main Dec 2, 2024
14 checks passed
@topepo topepo deleted the tunable-tailor branch December 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants