Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poisson log loss function update #513

Open
yonisidi opened this issue Jul 24, 2024 · 2 comments
Open

poisson log loss function update #513

yonisidi opened this issue Jul 24, 2024 · 2 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@yonisidi
Copy link

The original code for the poisson_log_loss was taken from {MLmetrics} and it works well overall, but has some edge cases when Inf is returned

eg dpois(ypred, 0) = 0, dpois(ypred, 0, log = TRUE) = -Inf

taking the mean of a vector with that you get Inf

{MLmetrics} has since updated their function to be aligned with the standard entropy loss function, which resolves this edge case.

would it be possible to update the yardstick function to re-align with {MLmetrics}? see @example in the {MLmetrics} link

@EmilHvitfeldt EmilHvitfeldt added the bug an unexpected problem or unintended behavior label Jul 25, 2024
@EmilHvitfeldt
Copy link
Member

Hello @yonisidi 👋

Sure would! I'll take a look next time to do a yardstick issue push

@yonisidi
Copy link
Author

awesome. ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants