Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display materialisation info by default #209

Open
hadley opened this issue Jul 25, 2024 · 1 comment
Open

Don't display materialisation info by default #209

hadley opened this issue Jul 25, 2024 · 1 comment
Milestone

Comments

@hadley
Copy link
Member

hadley commented Jul 25, 2024

e.g. in the readme:

out$mean_bill_area
#> materializing:
#> 
#> [1] 770.2627 656.8523 694.9360 819.7503 984.2279

I'd suggest something like:

out$mean_bill_area
#> materializing query: see last_materialization() for details
#> [1] 770.2627 656.8523 694.9360 819.7503 984.2279

last_materialization()
#> ---------------------
#> --- Relation Tree ---
#> ---------------------
#> Projection [species as species, sex as sex, mean_bill_area as mean_bill_area]
#>   Order [___row_number ASC]
#>     Filter [!=(species, 'Gentoo')]
#>       Projection [species as species, sex as sex, mean_bill_area as mean_bill_area, row_number() OVER () as ___row_number]
#>         Projection [species as species, sex as sex, mean_bill_area as mean_bill_area]
#>           Order [___row_number ASC]
#>             Aggregate [species, sex, min(___row_number), mean(bill_area)]
#>               Projection [species as species, island as island, bill_length_mm as bill_length_mm, bill_depth_mm as bill_depth_mm, flipper_length_mm as flipper_length_mm, body_mass_g as body_mass_g, sex as sex, "year" as year, bill_area as bill_area, row_number() OVER () as ___row_number]
#>                 Projection [species as species, island as island, bill_length_mm as bill_length_mm, bill_depth_mm as bill_depth_mm, flipper_length_mm as flipper_length_mm, body_mass_g as body_mass_g, sex as sex, "year" as year, *(bill_length_mm, bill_depth_mm) as bill_area]
#>                   r_dataframe_scan(0xdeadbeef)
#> 
#> ---------------------
#> -- Result Columns  --
#> ---------------------
#> - species (VARCHAR)
#> - sex (VARCHAR)
#> - mean_bill_area (DOUBLE)

And maybe have some option to suppress the notice about materialization altogether?

@hannes
Copy link
Contributor

hannes commented Sep 25, 2024

opt in only please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants