Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting seems broken on the website #252

Closed
etiennebacher opened this issue Aug 21, 2024 · 4 comments
Closed

Formatting seems broken on the website #252

etiennebacher opened this issue Aug 21, 2024 · 4 comments

Comments

@etiennebacher
Copy link

Hi, the formatting of the output of explain() seems broken on the website:

image

I'm using Firefox 128, but the same appears on Chrome 127, on Windows. I know the output is produced by duckdb upstream, but we had (maybe still have) similar issues in r-polars and I think it's a font issue.

@krlmlr
Copy link
Member

krlmlr commented Aug 21, 2024

Thanks, Etienne. Upstream: tidyverse/tidytemplate#83, but we can keep this open until it's fixed.

Do you remember what you did in r-polars to fix it?

CC @hadley @maelle.

@etiennebacher
Copy link
Author

I think it's still present (also in polars upstream: pola-rs/polars#11106) but in this case it only appears on Ubuntu or on mobile, so we never properly addressed it.

Here's a pending PR in upstream that might give you ideas: pola-rs/polars#18187

@hadley
Copy link
Member

hadley commented Aug 21, 2024

Putting my discussion in pola-rs/polars#18187 (comment); let's close this issue so there's one less place for discussion.

@hadley hadley closed this as completed Aug 21, 2024
@krlmlr
Copy link
Member

krlmlr commented Aug 21, 2024

Just FYI, I replaced the fancy dashes with plain dashes in ffcc1d9, to be deployed to the main site (but not yet to the dev site) by https://github.com/tidyverse/duckplyr/actions/runs/10495922741. We can keep experimenting on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants