Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance regression in CRAN release #514

Open
TimTaylor opened this issue Jan 28, 2025 · 1 comment
Open

performance regression in CRAN release #514

TimTaylor opened this issue Jan 28, 2025 · 1 comment

Comments

@TimTaylor
Copy link
Contributor

I've noticed some large performance regressions in the CRAN release (0.4.1) compared to an earlier release (0.3.2).

An example, which I've noticed run ~30-50x slower is

gh1 <- function() {
    out <-
        taxi_dat |>
        as_duckplyr_df() |>
        filter(total_amount > 0) |>
        mutate(
            tip_pct = 100 * tip_amount / total_amount,
            dn = lubridate::wday(pickup_datetime),
            hr = lubridate::hour(pickup_datetime)
        ) |>
        summarise(avg_tip_pct = mean(tip_pct), n = n(), .by = c(dn, hr)) |>
        arrange(desc(avg_tip_pct)) |>
        as.data.frame()

    nrow(out) # force it's collection (just in case)
    out
}

Here taxi_dat is a data frame of 3 months of the NY taxi data set.

These seem to have been resolved in the main branch (0.99.99.9923) but I'm wondering if there is something obvious I can alter to regain 0.3.2 performance in the current release?

@krlmlr
Copy link
Member

krlmlr commented Jan 29, 2025

Thanks. The best option at this stage is to wait a few more days for the 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants