Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oops, forgot to log body in non-streaming cases #232

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

jcheng5
Copy link
Collaborator

@jcheng5 jcheng5 commented Dec 18, 2024

Repro:

library(elmer)

options(elmer_verbosity = 2)

chat <- chat_claude(model = "claude-3-5-sonnet-latest")
chat$chat("Hello.", echo = FALSE)
chat$chat_async("Hello.")

Without this fix, both of these log the requests but not the responses. (Note that in Positron, catting from async handlers doesn't always work, so the chat_async verbose output may not appear. Works fine from the terminal and presumably RStudio.)

@jcheng5 jcheng5 requested a review from hadley December 18, 2024 19:56
@hadley
Copy link
Member

hadley commented Dec 18, 2024

This just confused me!

@hadley hadley merged commit ddadc17 into main Dec 18, 2024
10 of 11 checks passed
@hadley hadley deleted the more-logging branch December 18, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants